From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C74A8C3A59F for ; Thu, 29 Aug 2019 10:21:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 986BC22CF5 for ; Thu, 29 Aug 2019 10:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567074080; bh=g1Vo69At6c1xR0l7nlKwcgX9mVRHSUIsRWGGsUzYoAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=FM3DGRiE2j5SYxM2T/KSLZ1cfNfVG9ZUbZnBgw8dHMkxtRa21koKGPvwxqnsIwJST lxxVSP8xbzNan2JHOCpuJWzNPKnIwoMijlDPevnk4kva9JsjGtHlFrpTPCVGiQaaQ3 0W28eEWe+p4hXGVdG1bKanO6L8sceUdvoVA3NSP8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727188AbfH2KVR (ORCPT ); Thu, 29 Aug 2019 06:21:17 -0400 Received: from mail.kernel.org ([198.145.29.99]:58252 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727139AbfH2KVR (ORCPT ); Thu, 29 Aug 2019 06:21:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9A1E922CF5; Thu, 29 Aug 2019 10:21:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1567074076; bh=g1Vo69At6c1xR0l7nlKwcgX9mVRHSUIsRWGGsUzYoAY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DYIm9hOxhnnU9A/2IiunPz+jZr1vZXI9Ept0UHjkqAmu6KeVq1+6W2m+6DBLD3slu kKBtsuMIemVcKV92CVvNBmzhiRL3WAIcnC3rJ1YgrCMh5VoDR6zA5y+Y/YDMyabdn1 WF47KVgyK3xnhjMp9V9j01KxWHuxNTNF8EKJmH7U= Date: Thu, 29 Aug 2019 12:21:13 +0200 From: Greg Kroah-Hartman To: Marek Szyprowski Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, Martin Blumenstingl , Mathias Nyman , Felipe Balbi , Bartlomiej Zolnierkiewicz , Krzysztof Kozlowski , Jochen Sprickerhof , Anand Moon Subject: Re: [PATCH v2 1/2 RESEND] usb: core: phy: add support for PHY calibration Message-ID: <20190829102113.GA20823@kroah.com> References: <20190808094128.27213-1-m.szyprowski@samsung.com> <20190808094128.27213-2-m.szyprowski@samsung.com> <20190828204146.GA21235@kroah.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Aug 29, 2019 at 07:26:50AM +0200, Marek Szyprowski wrote: > Hi Greg, > > On 2019-08-28 22:41, Greg Kroah-Hartman wrote: > > On Mon, Aug 26, 2019 at 10:55:33AM +0200, Marek Szyprowski wrote: > >> Hi Greg > >> > >> On 2019-08-08 11:41, Marek Szyprowski wrote: > >>> Some PHYs (for example Exynos5 USB3.0 DRD PHY) require calibration to be > >>> done after every USB HCD reset. Generic PHY framework has been already > >>> extended with phy_calibrate() function in commit 36914111e682 ("drivers: > >>> phy: add calibrate method"). This patch adds support for it to generic > >>> PHY handling code in USB HCD core. > >>> > >>> Signed-off-by: Marek Szyprowski > >>> Tested-by: Anand Moon > >>> Tested-by: Jochen Sprickerhof > >> Greg: any chance to give it this a try in -next? If not, maybe You can > >> point someone whose review will help? > > Ah crap, this is me, not the PHY maintainer :( > > > > Can you resend this and I will be glad to review it. But it would also > > be good to get Felipe's review as well. > > No problem, I will resend it again in a few minutes. Felipe already > acked it: https://lkml.org/lkml/2019/8/8/460 I don't see the resend, did I miss it? And can you add Felipe's ack to it? thanks, greg k-h