From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1B95C49ED6 for ; Wed, 11 Sep 2019 10:05:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C652921479 for ; Wed, 11 Sep 2019 10:05:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727541AbfIKKFJ (ORCPT ); Wed, 11 Sep 2019 06:05:09 -0400 Received: from eddie.linux-mips.org ([148.251.95.138]:58490 "EHLO cvs.linux-mips.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727090AbfIKKFJ (ORCPT ); Wed, 11 Sep 2019 06:05:09 -0400 Received: (from localhost user: 'ladis' uid#1021 fake: STDIN (ladis@eddie.linux-mips.org)) by eddie.linux-mips.org id S23994598AbfIKKFGpWut1 (ORCPT ); Wed, 11 Sep 2019 12:05:06 +0200 Date: Wed, 11 Sep 2019 12:05:05 +0200 From: Ladislav Michl To: Felipe Balbi Cc: linux-usb@vger.kernel.org, =?iso-8859-2?Q?Micha=B3_Miros=B3aw?= , Greg Kroah-Hartman Subject: Re: [PATCH v5 2/6] usb: gadget: u_serial: reimplement console support Message-ID: <20190911100505.GA9950@lenoch> References: <0dd7dc4d5135b838d8f0fe98d0a689163cc9dda8.1563809035.git.mirq-linux@rere.qmqm.pl> <87r25utufw.fsf@gmail.com> <20190810081105.GA10667@qmqm.qmqm.pl> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20190810081105.GA10667@qmqm.qmqm.pl> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Hi Felipe, On Sat, Aug 10, 2019 at 10:11:05AM +0200, Michał Mirosław wrote: > On Fri, Aug 09, 2019 at 03:05:55PM +0300, Felipe Balbi wrote: > > > > Hi, > > > > Michał Mirosław writes: > > > Rewrite console support to fix a few shortcomings of the old code > > > preventing its use with multiple ports. This removes some duplicated > > > code and replaces a custom kthread with simpler workqueue item. > > > > > > Only port ttyGS0 gets to be a console for now. > > > > > > Signed-off-by: Michał Mirosław > > > Reviewed-by: Greg Kroah-Hartman > > > Tested-by: Ladislav Michl > > > > checking file drivers/usb/gadget/function/u_serial.c > > Hunk #7 FAILED at 1206. > > Hunk #8 succeeded at 1302 (offset -2 lines). > > Hunk #9 succeeded at 1334 (offset -2 lines). > > Hunk #10 succeeded at 1363 (offset -2 lines). > > 1 out of 10 hunks FAILED > > > > Could you rebase on my testing/next? I do not see this patch in -next and there were no more comments from you. Is there anything else you need to review patchset? Thanks, ladis > Sure. Should be ready in a few minutes. > > Best Regards, > Michał Mirosław