From: Matthias Kaehlcke <mka@chromium.org>
To: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
Cc: balbi@kernel.org, agross@kernel.org, david.brown@linaro.org,
linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 1/3] dt-bindings: Introduce interconnect bindings for usb
Date: Mon, 16 Sep 2019 14:19:14 -0700 [thread overview]
Message-ID: <20190916211914.GF133864@google.com> (raw)
In-Reply-To: <1568177675-18764-2-git-send-email-cchiluve@codeaurora.org>
On Wed, Sep 11, 2019 at 10:24:33AM +0530, Chandana Kishori Chiluveru wrote:
> Add documentation for the interconnects and interconnect-names
> bindings for USB as detailed by bindings/interconnect/interconnect.txt.
This isn't a generic binding for USB, but for the qcom,dwc3, the
commit message (including subject) should reflect this.
nit: you might want to replace 'bindings' with 'properties'.
> Signed-off-by: Chandana Kishori Chiluveru <cchiluve@codeaurora.org>
> ---
> Documentation/devicetree/bindings/usb/qcom,dwc3.txt | 13 +++++++++++++
> 1 file changed, 13 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> index cb695aa..7e9cb97 100644
> --- a/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> +++ b/Documentation/devicetree/bindings/usb/qcom,dwc3.txt
> @@ -33,6 +33,16 @@ Optional clocks:
>
> Optional properties:
> - resets: Phandle to reset control that resets core and wrapper.
> +- interconnects: Pairs of phandles and interconnect provider specifier
consistency nit: should be either 'phandle' & 'specifier' or
'phandles' & 'specifiers'.
next prev parent reply other threads:[~2019-09-16 21:19 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-11 4:54 [PATCH 0/3] ADD interconnect support for USB Chandana Kishori Chiluveru
2019-09-11 4:54 ` [PATCH 1/3] dt-bindings: Introduce interconnect bindings for usb Chandana Kishori Chiluveru
2019-09-16 21:19 ` Matthias Kaehlcke [this message]
2019-09-11 4:54 ` [PATCH 2/3] usb: dwc3: qcom: Add interconnect support in dwc3 driver Chandana Kishori Chiluveru
2019-09-12 12:54 ` Georgi Djakov
2019-09-11 4:54 ` [PATCH 3/3] arm64: dts: sdm845: Add interconnect properties for USB Chandana Kishori Chiluveru
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190916211914.GF133864@google.com \
--to=mka@chromium.org \
--cc=agross@kernel.org \
--cc=balbi@kernel.org \
--cc=cchiluve@codeaurora.org \
--cc=david.brown@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).