From: Greg KH <gregkh@linuxfoundation.org>
To: David Heinzelmann <heinzelmann.david@gmail.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection.
Date: Fri, 20 Sep 2019 14:15:38 +0200 [thread overview]
Message-ID: <20190920121538.GA549982@kroah.com> (raw)
In-Reply-To: <20190920131726.GA5913@dhe-pc>
On Fri, Sep 20, 2019 at 03:17:26PM +0200, David Heinzelmann wrote:
> Hi,
>
> sorry for the wrong patch format.
No problem, that's normal. But please do not top-post on linux mailing
lists.
> I am trying to detect a change. At the moment I think the change could be ignored if a
> port connection-change occurs and the port status has again the 'PORT_CONNECTION' bit set.
>
> I have a fx3 device which does a re-enumeration after a firmware download. This is working
> as expected and I am seeing a 'remove event' and a 'add event' monitoring via udevadm. But
> if I connect multiple devices at the same time via an usb hub I am sometimes not receiving
> a 'remove event' and 'add event' for a single device.
Sounds like a broken hub :)
> I think the problem could be that when a device disconnects and the port connection-change
> occurs and before the 'PORT_CONNECTION' bit is checked the device could already be
> reconnected and the 'PORT_CONNECTION' bit is set. Therefore I think it is not correct to
> resuscitate the exisiting device.
Does your patch actually fix the issue? When a fx3 device downloads
firmware and re-enumerates, it should come back as a totally different
device, which will fail this check, right? So I don't see how this
fixes the issues with your devices.
Unless all of the devices reset themselves at the same time and the hub
doesn't like that and can't notice that it happened?
If you use a different hub, does that work properly?
thanks,
greg k-h
next prev parent reply other threads:[~2019-09-20 12:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-20 10:36 [PATCH] Check for changed device descriptors when a connection-change occurs before validating the connection David Heinzelmann
2019-09-20 8:55 ` Greg KH
2019-09-20 13:17 ` David Heinzelmann
2019-09-20 12:15 ` Greg KH [this message]
2019-09-20 15:33 ` David Heinzelmann
2019-09-23 14:49 ` Alan Stern
2019-09-24 10:01 ` David Heinzelmann
2019-09-25 14:20 ` Alan Stern
2019-09-30 7:26 ` David Heinzelmann
2019-09-30 14:25 ` Alan Stern
2019-10-04 13:23 ` David Heinzelmann
2019-10-04 14:17 ` Alan Stern
2019-10-07 8:47 ` David Heinzelmann
2019-10-07 14:01 ` Alan Stern
2019-10-07 15:35 ` Greg KH
2019-10-08 8:09 ` [PATCH v4] usb: hub: Check device descriptor before resusciation David Heinzelmann
2019-10-08 12:55 ` Greg KH
2019-10-08 16:10 ` David Heinzelmann
2019-10-08 15:17 ` Greg KH
2019-10-09 4:46 ` [PATCH v5] " David Heinzelmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190920121538.GA549982@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=heinzelmann.david@gmail.com \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).