Linux USB
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Pawel Laszczak <pawell@cadence.com>
Cc: linux-usb@vger.kernel.org, felipe.balbi@linux.intel.com,
	dan.carpenter@oracle.com
Subject: Re: [PATCH -next] usb: cdns3: Fix sheduling with locks held.
Date: Thu, 26 Sep 2019 09:23:16 +0200	[thread overview]
Message-ID: <20190926072316.GA1581871@kroah.com> (raw)
In-Reply-To: <1569481230-14120-1-git-send-email-pawell@cadence.com>

On Thu, Sep 26, 2019 at 08:00:30AM +0100, Pawel Laszczak wrote:
> Patch fix issue in cdns3_ep0_feature_handle_device function.
> 
> The function usleep_range can't be used there because this function is
> called with locks held and IRQs disabled in
> cdns3_device_thread_irq_handler().
> 
> To resolve this issue patch replaces usleep_range with mdelay.
> 
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Pawel Laszczak <pawell@cadence.com>
> Fixes: 7733f6c32e36 ("usb: cdns3: Add Cadence USB3 DRD Driver")
> ---
>  drivers/usb/cdns3/ep0.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Is this v2 of the patch?

If so, it needs to be said so in the subject line, and below the ---
line describe what changed from the previous one.

That should all be described in the kernel documentation, right?

v3 please?

thanks,

greg k-h

  reply	other threads:[~2019-09-26  7:23 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-26  7:00 [PATCH -next] usb: cdns3: Fix sheduling with locks held Pawel Laszczak
2019-09-26  7:23 ` Greg KH [this message]
2019-09-26  7:28   ` Pawel Laszczak
  -- strict thread matches above, loose matches on Subject: below --
2019-09-26  6:19 Pawel Laszczak
2019-09-26  6:33 ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190926072316.GA1581871@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=dan.carpenter@oracle.com \
    --cc=felipe.balbi@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox