From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNWANTED_LANGUAGE_BODY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E857BC432C2 for ; Thu, 26 Sep 2019 09:12:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BD1AA222C4 for ; Thu, 26 Sep 2019 09:12:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1569489167; bh=D0IHdoYL+cdWFefW3ed7cXAIOAxO7+Hp43rw32M1Kyw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ikNI0huWreJmw4OWtMY3rpm05oWEGpObaZqJICsys/RnTHGgzZXpJTo6IhwxOmSxP wOGpF3q5U7Xy3dsGj1EO+8UXyuV7iY3tB6jsM2A9iUn6/T6jetJqDKRRxgqHBNjBVw W+iWqHJELR0dzcKwJTez53fECJYdP0pLd3ybcWoU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727670AbfIZJMr (ORCPT ); Thu, 26 Sep 2019 05:12:47 -0400 Received: from mail-lf1-f67.google.com ([209.85.167.67]:38338 "EHLO mail-lf1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725812AbfIZJMr (ORCPT ); Thu, 26 Sep 2019 05:12:47 -0400 Received: by mail-lf1-f67.google.com with SMTP id u28so1125452lfc.5 for ; Thu, 26 Sep 2019 02:12:45 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=E6Ii7hCmgGJll6q9WG6b8f58XKzO8877IKSX+QpN4qo=; b=YI3wutf/ElDRx7XsXYi1NP8BhzFETZjFGBLDIQLm38+BbPY26+I/xvVl4Kf2KG0wc5 dq6wB8l0tMVH98FJU/oJr7+mCBvmXb5LQIVMepDoMnA9QrnK2bLP/nBGIDyN7qFpvsQg lFjWaHbHf+WGCvSjHMQJbZDIY5XVTKbkv6xSZhlxvRqRDfj7+9iHnWXNtOn57PwF394Y 7S8DE69/l43fW0jJx64IIw252+c4m/1cSuo1+i1fMYTXlXOomK9o1iXDmOMewKrhyrpa VrWZVfXnLNSK0wVbyrqrDFIhAEc0l1c35hiUV39zWa98hNSLPSTqMcBl/NT6LS8vLoIC QnJg== X-Gm-Message-State: APjAAAVLfwckmUe06azdqhK1JNi2nVXvC02xn+5cIRxJ82LOQhfvGFq/ 10PoTcEemdZWOoCuDus720c= X-Google-Smtp-Source: APXvYqxIDREq4E80Ti66gvr0+gA6T790Z2yvXkLHsAgcATwR+2W94XAqfOo6dZrfVRsE4UoLsCB7Xw== X-Received: by 2002:a19:6001:: with SMTP id u1mr1529141lfb.50.1569489165002; Thu, 26 Sep 2019 02:12:45 -0700 (PDT) Received: from xi.terra (c-51f1e055.07-184-6d6c6d4.bbcust.telenor.se. [85.224.241.81]) by smtp.gmail.com with ESMTPSA id r22sm377634ljr.43.2019.09.26.02.12.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 26 Sep 2019 02:12:43 -0700 (PDT) Received: from johan by xi.terra with local (Exim 4.92.2) (envelope-from ) id 1iDPpR-0006Qb-U9; Thu, 26 Sep 2019 11:12:49 +0200 From: Johan Hovold To: Greg Kroah-Hartman Cc: linux-usb@vger.kernel.org, Johan Hovold Subject: [PATCH 3/4] USB: usblcd: drop redundant lcd mutex Date: Thu, 26 Sep 2019 11:12:22 +0200 Message-Id: <20190926091228.24634-4-johan@kernel.org> X-Mailer: git-send-email 2.23.0 In-Reply-To: <20190926091228.24634-1-johan@kernel.org> References: <20190926091228.24634-1-johan@kernel.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Drop the redundant lcd mutex introduced by commit 925ce689bb31 ("USB: autoconvert trivial BKL users to private mutex") which replaced an earlier BKL use. The lock serialised calls to open() against other open() and a custom ioctl() returning the bcdDevice (sic!), but neither is needed. Signed-off-by: Johan Hovold --- drivers/usb/misc/usblcd.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/usb/misc/usblcd.c b/drivers/usb/misc/usblcd.c index b898650a5570..732eb1f81368 100644 --- a/drivers/usb/misc/usblcd.c +++ b/drivers/usb/misc/usblcd.c @@ -30,7 +30,6 @@ #define IOCTL_GET_DRV_VERSION 2 -static DEFINE_MUTEX(lcd_mutex); static const struct usb_device_id id_table[] = { { .idVendor = 0x10D2, .match_flags = USB_DEVICE_ID_MATCH_VENDOR, }, { }, @@ -81,12 +80,10 @@ static int lcd_open(struct inode *inode, struct file *file) struct usb_interface *interface; int subminor, r; - mutex_lock(&lcd_mutex); subminor = iminor(inode); interface = usb_find_interface(&lcd_driver, subminor); if (!interface) { - mutex_unlock(&lcd_mutex); printk(KERN_ERR "USBLCD: %s - error, can't find device for minor %d\n", __func__, subminor); return -ENODEV; @@ -101,13 +98,11 @@ static int lcd_open(struct inode *inode, struct file *file) r = usb_autopm_get_interface(interface); if (r < 0) { kref_put(&dev->kref, lcd_delete); - mutex_unlock(&lcd_mutex); return r; } /* save our object in the file's private structure */ file->private_data = dev; - mutex_unlock(&lcd_mutex); return 0; } @@ -176,14 +171,12 @@ static long lcd_ioctl(struct file *file, unsigned int cmd, unsigned long arg) switch (cmd) { case IOCTL_GET_HARD_VERSION: - mutex_lock(&lcd_mutex); bcdDevice = le16_to_cpu((dev->udev)->descriptor.bcdDevice); sprintf(buf, "%1d%1d.%1d%1d", (bcdDevice & 0xF000)>>12, (bcdDevice & 0xF00)>>8, (bcdDevice & 0xF0)>>4, (bcdDevice & 0xF)); - mutex_unlock(&lcd_mutex); if (copy_to_user((void __user *)arg, buf, strlen(buf)) != 0) return -EFAULT; break; -- 2.23.0