From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Yizhuo <yzhai003@ucr.edu>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Kai-Heng Feng <kai.heng.feng@canonical.com>,
Mathias Nyman <mathias.nyman@linux.intel.com>,
Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
Douglas Anderson <dianders@chromium.org>,
Nicolas Saenz Julienne <nsaenzjulienne@suse.de>,
Jan-Marek Glogowski <glogow@fbihome.de>,
Mathieu Malaterre <malat@debian.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: core: Fix potental Null Pointer dereference
Date: Thu, 10 Oct 2019 07:20:25 +0200 [thread overview]
Message-ID: <20191010052025.GA235874@kroah.com> (raw)
In-Reply-To: <20191010010205.25739-1-yzhai003@ucr.edu>
On Wed, Oct 09, 2019 at 06:02:02PM -0700, Yizhuo wrote:
> Inside function usb_device_is_owned(), usb_hub_to_struct_hub()
> could return NULL but there's no check before its dereference,
> which is potentially unsafe.
>
> Signed-off-by: Yizhuo <yzhai003@ucr.edu>
> ---
> drivers/usb/core/hub.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/usb/core/hub.c b/drivers/usb/core/hub.c
> index 236313f41f4a..8d628c8e0c1b 100644
> --- a/drivers/usb/core/hub.c
> +++ b/drivers/usb/core/hub.c
> @@ -1977,7 +1977,7 @@ bool usb_device_is_owned(struct usb_device *udev)
> if (udev->state == USB_STATE_NOTATTACHED || !udev->parent)
> return false;
> hub = usb_hub_to_struct_hub(udev->parent);
> - return !!hub->ports[udev->portnum - 1]->port_owner;
> + return hub && !!hub->ports[udev->portnum - 1]->port_owner;
How can hub ever not be valid?
thanks,
greg k-h
prev parent reply other threads:[~2019-10-10 5:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 1:02 [PATCH] USB: core: Fix potental Null Pointer dereference Yizhuo
2019-10-10 5:20 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191010052025.GA235874@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=dianders@chromium.org \
--cc=glogow@fbihome.de \
--cc=kai.heng.feng@canonical.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=malat@debian.org \
--cc=mathias.nyman@linux.intel.com \
--cc=nsaenzjulienne@suse.de \
--cc=stern@rowland.harvard.edu \
--cc=yzhai003@ucr.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).