From: GwanYeong Kim <gy741.kim@gmail.com>
To: shuah <shuah@kernel.org>
Cc: valentina.manea.m@gmail.com, gregkh@linuxfoundation.org,
allison@lohutok.net, opensource@jilayne.com,
changcheng.liu@intel.com, tglx@linutronix.de,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2] usbip: tools: Fix read_usb_vudc_device() error path handling
Date: Thu, 17 Oct 2019 14:26:05 +0900 [thread overview]
Message-ID: <20191017142605.000041f6@gmail.com> (raw)
In-Reply-To: <e460e4fb-cefa-9dea-f0f6-7e92f3727034@kernel.org>
On Wed, 16 Oct 2019 20:33:39 -0600
shuah <shuah@kernel.org> wrote:
> On 10/16/19 8:25 PM, GwanYeong Kim wrote:
> > cannot be less than 0 - fread() returns 0 on error.
> >
>
> This isn't really accurate right. fread() doesn't always
> return 0 in error. It could return < number of elements
> and set errno.
>
> Please make changes to reflect that.
Will reflect this.
>
> > Signed-off-by: GwanYeong Kim <gy741.kim@gmail.com>
> > ---
> > tools/usb/usbip/libsrc/usbip_device_driver.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c
> > b/tools/usb/usbip/libsrc/usbip_device_driver.c index
> > 051d7d3f443b..959bb29d0477 100644 ---
> > a/tools/usb/usbip/libsrc/usbip_device_driver.c +++
> > b/tools/usb/usbip/libsrc/usbip_device_driver.c @@ -69,7 +69,7 @@
> > int read_usb_vudc_device(struct udev_device *sdev, struct
> > usbip_usb_device *dev) FILE *fd = NULL; struct udev_device *plat;
> > const char *speed;
> > - int ret = 0;
> > + size_t ret = 0;
>
> You don't need to initialize this.
Exactly, because "ret" variable receives a "fread()" return value,
>
> >
> > plat = udev_device_get_parent(sdev);
> > path = udev_device_get_syspath(plat);
> > @@ -79,7 +79,7 @@ int read_usb_vudc_device(struct udev_device
> > *sdev, struct usbip_usb_device *dev) if (!fd)
> > return -1;
> > ret = fread((char *) &descr, sizeof(descr), 1, fd);
> > - if (ret < 0)
> > + if (ret != 1)
>
> Why not print error message?
Sorry, I'll add a message.
How about this?
err("Cannot read vudc device descr file");
>
> > goto err;
> > fclose(fd);
> >
> >
>
> thanks,
> -- Shuah
next prev parent reply other threads:[~2019-10-17 5:26 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 13:14 [PATCH] usbip: tools: Fix read_usb_vudc_device() error path handling GwanYeong Kim
2019-10-15 23:14 ` shuah
2019-10-16 4:38 ` GwanYeong Kim
2019-10-16 13:18 ` Greg KH
2019-10-17 2:25 ` [PATCH v2] " GwanYeong Kim
2019-10-17 2:33 ` shuah
2019-10-17 5:26 ` GwanYeong Kim [this message]
2019-10-17 13:00 ` shuah
2019-10-18 3:22 ` [PATCH v3] " GwanYeong Kim
2019-10-21 18:59 ` shuah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191017142605.000041f6@gmail.com \
--to=gy741.kim@gmail.com \
--cc=allison@lohutok.net \
--cc=changcheng.liu@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-usb@vger.kernel.org \
--cc=opensource@jilayne.com \
--cc=shuah@kernel.org \
--cc=tglx@linutronix.de \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).