From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.2 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58D52CA9EA0 for ; Tue, 22 Oct 2019 14:56:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 3636721872 for ; Tue, 22 Oct 2019 14:56:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729871AbfJVO4y (ORCPT ); Tue, 22 Oct 2019 10:56:54 -0400 Received: from muru.com ([72.249.23.125]:38852 "EHLO muru.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726955AbfJVO4y (ORCPT ); Tue, 22 Oct 2019 10:56:54 -0400 Received: from atomide.com (localhost [127.0.0.1]) by muru.com (Postfix) with ESMTPS id 34B6E80FA; Tue, 22 Oct 2019 14:57:27 +0000 (UTC) Date: Tue, 22 Oct 2019 07:56:49 -0700 From: Tony Lindgren To: Yegor Yefremov Cc: Johan Hovold , Sebastian Reichel , Linux-OMAP , vkoul@kernel.org, Bin Liu , linux-usb , Andrey Skvortsov , Giulio Benetti , Sebastian Andrzej Siewior , Peter Ujfalusi Subject: Re: musb: cppi41: broken high speed FTDI functionality when connected to musb directly Message-ID: <20191022145649.GI5610@atomide.com> References: <20190930152330.GH5610@atomide.com> <20190930195411.6porqtm7tlokgel3@earth.universe> <20191001080339.GF13531@localhost> <20191001164351.GJ5610@atomide.com> <20191001220321.GK5610@atomide.com> <20191002165219.GL5610@atomide.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.12.1 (2019-06-15) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org * Yegor Yefremov [191021 01:40]: > Hi Tony, > > On Thu, Oct 3, 2019 at 10:39 AM Yegor Yefremov > wrote: > > > > Hi Tony, > > > > On Wed, Oct 2, 2019 at 6:52 PM Tony Lindgren wrote: > > > > > > * Yegor Yefremov [191002 06:57]: > > > > On Wed, Oct 2, 2019 at 12:03 AM Tony Lindgren wrote: > > > > > The other way to fix this would be to just wake up cpp41 in > > > > > cppi41_dma_prep_slave_sg() and return NULL so that we can > > > > > have musb_ep_program() continue with PIO while cppi41 is > > > > > asleep. > > > > > > > > > > Anyways, care to try it out and see if it fixes your issue? > > > > > > > > The fix is working but on the first invocation, I get this output > > > > (minicom provokes the same output): > > > > > > > # serialtest.py -c 2 /dev/ttyUSB0 /dev/ttyUSB0 > > > ... > > > > [ 210.940612] [] (__rpm_callback) from [] > > > > (rpm_callback+0x20/0x80) > > > > [ 210.948402] [] (rpm_callback) from [] > > > > (rpm_resume+0x468/0x7a0) > > > > [ 210.956018] [] (rpm_resume) from [] > > > > (__pm_runtime_resume+0x4c/0x64) > > > > [ 210.964086] [] (__pm_runtime_resume) from [] > > > > (cppi41_dma_prep_slave_sg+0x20/0xfc [cppi41]) > > > > > > OK so that won't work, thanks for testing. Here's the alternative > > > patch to try along the lines described above that just wakes up > > > cppi41 and returns NULL so musb_ep_program() can continue with PIO > > > until cppi41 is awake. > > > > I'm out of the office for some weeks and don't have access to my hw. > > I'll make the test as soon as I'm back. > > I've tested your patch with both systems (with and without a hub) and > everything is working as expected. OK good to hear, I just sent it out with a proper description as: [PATCH] dmaengine: cppi41: Fix issue with musb and ftdi uart Regards, Tony