From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B3CB6CA9EA0 for ; Fri, 25 Oct 2019 14:02:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8043620679 for ; Fri, 25 Oct 2019 14:02:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572012144; bh=ISAo5vn+007S4sNbFtUYwHTVpHMeCjtJiDa8U5Y8dL8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=DWEAGN6NggD4k9zfj1b9MlKGtyLVx7kdAA88dpzFX+U8jl10J0QZpDOKsPju2dOy6 T+Z3uuj8aZgIBQocUZE324nFtqRc9hJCZHdYJ8047oJks0Oh3antSxUsLbtDbY7ICV 5WQ1YmWuGG3aNVG1dT6dA9hlpV0JGYjVjXcU5Nqk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2394926AbfJYOCO (ORCPT ); Fri, 25 Oct 2019 10:02:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:52794 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2505375AbfJYN5t (ORCPT ); Fri, 25 Oct 2019 09:57:49 -0400 Received: from sasha-vm.mshome.net (c-73-47-72-35.hsd1.nh.comcast.net [73.47.72.35]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A0E6D21D82; Fri, 25 Oct 2019 13:57:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1572011868; bh=ISAo5vn+007S4sNbFtUYwHTVpHMeCjtJiDa8U5Y8dL8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=pU3ZFbSxEqArx4Trc+gBG8b1CXa4i4cVhXgFuONM6S8vdkSX2E3IfMiPoyHczKyZz 1mtm6Oe8MP67Ew77DtoJQKO5YI8lzG83P7KUjzfE3F+u7Ux096nfUpZY0VGhQGhq28 IiiXZkkLcVlAFjKA5T3YY/5Z1J7THsHSEV/EOV0M= From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Valentin Vidic , syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com, "David S . Miller" , Sasha Levin , linux-usb@vger.kernel.org, netdev@vger.kernel.org Subject: [PATCH AUTOSEL 4.14 18/25] net: usb: sr9800: fix uninitialized local variable Date: Fri, 25 Oct 2019 09:57:06 -0400 Message-Id: <20191025135715.25468-18-sashal@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20191025135715.25468-1-sashal@kernel.org> References: <20191025135715.25468-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore Content-Transfer-Encoding: 8bit Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org From: Valentin Vidic [ Upstream commit 77b6d09f4ae66d42cd63b121af67780ae3d1a5e9 ] Make sure res does not contain random value if the call to sr_read_cmd fails for some reason. Reported-by: syzbot+f1842130bbcfb335bac1@syzkaller.appspotmail.com Signed-off-by: Valentin Vidic Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/usb/sr9800.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/usb/sr9800.c b/drivers/net/usb/sr9800.c index 35f39f23d8814..8f8c9ede88c26 100644 --- a/drivers/net/usb/sr9800.c +++ b/drivers/net/usb/sr9800.c @@ -336,7 +336,7 @@ static void sr_set_multicast(struct net_device *net) static int sr_mdio_read(struct net_device *net, int phy_id, int loc) { struct usbnet *dev = netdev_priv(net); - __le16 res; + __le16 res = 0; mutex_lock(&dev->phy_mutex); sr_set_sw_mii(dev); -- 2.20.1