From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Peter Robinson <pbrobinson@gmail.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
Thierry Reding <thierry.reding@gmail.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
linux-usb@vger.kernel.org, linux-tegra@vger.kernel.org
Subject: Re: [PATCH] usb: host: xhci-tegra: set MODULE_FIRMWARE for tegra186
Date: Mon, 4 Nov 2019 16:21:41 +0100 [thread overview]
Message-ID: <20191104152141.GA2252233@kroah.com> (raw)
In-Reply-To: <CALeDE9PJVLnRvCDTNQcC9jNKGZL0Vo9d0xRrMzcSP8TEaNcS8w@mail.gmail.com>
On Mon, Nov 04, 2019 at 03:07:48PM +0000, Peter Robinson wrote:
> On Mon, Nov 4, 2019 at 2:57 PM Greg Kroah-Hartman
> <gregkh@linuxfoundation.org> wrote:
> >
> > On Sat, Nov 02, 2019 at 05:26:06PM +0000, Peter Robinson wrote:
> > > Set the MODULE_FIRMWARE for tegra186, it's registered for 124/210 and
> > > ensures the firmware is available at the appropriate time such as in
> > > the initrd, else if the firmware is unavailable the driver fails with
> > > the following errors:
> > >
> > > tegra-xusb 3530000.usb: Direct firmware load for nvidia/tegra186/xusb.bin failed with error -2
> > > tegra-xusb 3530000.usb: failed to request firmware: -2
> > > tegra-xusb 3530000.usb: failed to load firmware: -2
> > > tegra-xusb: probe of 3530000.usb failed with error -2
> > >
> > > Fixes: 5f9be5f3f899 ("usb: host: xhci-tegra: Add Tegra186 XUSB support")
> > > Fixes: 488a04d4bb2f ("arm64: tegra: Enable XUSB host controller on Jetson TX2")
> >
> > There is no such git id in Linus's tree :(
>
> Tha'ts in the tegra tree for 5.5.
>
> > This also doesn't apply cleanly to the usb tree, so I don't know where
> > you want it to go, sorry.
>
> Where is that? I can rebase against it, I'm guessing the tegra194 bits landed.
usb.git on git.kernel.org.
And yes, it did. But when I applied the above patch, my checks for
valid fixes: ids failed so I can't take this as-is.
thanks,
greg k-h
prev parent reply other threads:[~2019-11-04 15:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-02 17:26 [PATCH] usb: host: xhci-tegra: set MODULE_FIRMWARE for tegra186 Peter Robinson
2019-11-02 17:43 ` Thierry Reding
2019-11-02 18:39 ` Peter Robinson
2019-11-04 9:06 ` Thierry Reding
2019-11-04 14:56 ` Greg Kroah-Hartman
2019-11-04 15:07 ` Peter Robinson
2019-11-04 15:21 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191104152141.GA2252233@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jonathanh@nvidia.com \
--cc=linux-tegra@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=pbrobinson@gmail.com \
--cc=thierry.reding@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).