From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E9294C43331 for ; Mon, 11 Nov 2019 13:28:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BE04C2196E for ; Mon, 11 Nov 2019 13:28:34 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727040AbfKKN2e (ORCPT ); Mon, 11 Nov 2019 08:28:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:40934 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726910AbfKKN2e (ORCPT ); Mon, 11 Nov 2019 08:28:34 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9D3AE2196E; Mon, 11 Nov 2019 13:28:31 +0000 (UTC) Date: Mon, 11 Nov 2019 14:28:29 +0100 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, stable Subject: Re: [PATCH 2/2] USB: serial: mos7840: fix remote wakeup Message-ID: <20191111132829.GC450958@kroah.com> References: <20191107132119.2159-1-johan@kernel.org> <20191107132119.2159-2-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191107132119.2159-2-johan@kernel.org> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Nov 07, 2019 at 02:21:19PM +0100, Johan Hovold wrote: > The driver was setting the device remote-wakeup feature during probe in > violation of the USB specification (which says it should only be set > just prior to suspending the device). This could potentially waste > power during suspend as well as lead to spurious wakeups. > > Note that USB core would clear the remote-wakeup feature at first > resume. > > Fixes: 3f5429746d91 ("USB: Moschip 7840 USB-Serial Driver") > Cc: stable # 2.6.19 > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/mos7840.c | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/drivers/usb/serial/mos7840.c b/drivers/usb/serial/mos7840.c > index 3eeeee38debc..ab4bf8d6d7df 100644 > --- a/drivers/usb/serial/mos7840.c > +++ b/drivers/usb/serial/mos7840.c > @@ -2290,11 +2290,6 @@ static int mos7840_port_probe(struct usb_serial_port *port) > goto error; > } else > dev_dbg(&port->dev, "ZLP_REG5 Writing success status%d\n", status); > - > - /* setting configuration feature to one */ > - usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), > - 0x03, 0x00, 0x01, 0x00, NULL, 0x00, > - MOS_WDR_TIMEOUT); > } > return 0; > error: > -- > 2.23.0 Reviewed-by: Greg Kroah-Hartman