From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C25C33C8C for ; Thu, 14 Nov 2019 03:20:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0AF14206F6 for ; Thu, 14 Nov 2019 03:20:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573701627; bh=OtP6MQL/9zqWPLBJmcEhDTenHXMX6HLpeiVYH4UmMDE=; h=Date:From:To:Subject:References:In-Reply-To:List-ID:From; b=wBirrz81LbDJOD9T+QRV1Mn1GTev2R6wyIbxHbALf7LvBU6TFA20tVGf/1R9bvYdu mMibEUl/4vAF3rz6clXoYugrXFMQ7S8lnNek0szL48E3VE8B+XWpEEpz9yTisy/5ax 2/GsevYVtDii6iSRQ16Dq//H5XL5pwbMvqGUrxUM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726557AbfKNDUW (ORCPT ); Wed, 13 Nov 2019 22:20:22 -0500 Received: from mail.kernel.org ([198.145.29.99]:59278 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbfKNDUW (ORCPT ); Wed, 13 Nov 2019 22:20:22 -0500 Received: from localhost (unknown [124.219.31.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CBE25206F3; Thu, 14 Nov 2019 03:20:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573701621; bh=OtP6MQL/9zqWPLBJmcEhDTenHXMX6HLpeiVYH4UmMDE=; h=Date:From:To:Subject:References:In-Reply-To:From; b=gQLXWXktL91SJAhfZP1kDUlvFwg3yUAhxTlw3gEyBZm+csv1Fe3nn+RAgRYOGy8zH MrSA9ov5qkWicZMsu5PnaUDmANrLHTjaP2NrEUP2gsBQBdTLLG9FbXwLZ1HPjT/uxn CEEBcRjEjnPcIOLb6WihxH/e2FQ07IVp9PbR/Az4= Date: Thu, 14 Nov 2019 11:20:18 +0800 From: Greg Kroah-Hartman To: Bin Liu , Chunfeng Yun , Felipe Balbi , Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Matthias Brugger , Stephen Boyd , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 05/13] usb: musb: create debugfs directory under usb root Message-ID: <20191114032018.GA122287@kroah.com> References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> <1573541519-28488-5-git-send-email-chunfeng.yun@mediatek.com> <20191112152857.GA5853@uda0271908> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191112152857.GA5853@uda0271908> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Nov 12, 2019 at 09:28:57AM -0600, Bin Liu wrote: > Hi, > > On Tue, Nov 12, 2019 at 02:51:51PM +0800, Chunfeng Yun wrote: > > Now the USB gadget subsystem can use the USB debugfs root directory, > > so move musb's directory from the root of the debugfs filesystem into > > the root of usb > > My opinion is this move is unnecessary. I breaks existing debug tools or > documentation which is already published on Internet. Having a "root" directory for a single random driver seems like you are making your driver a "very important" thing in the overall scheme of the kernel, right? What's wrong with using the usb subdirectory like all other USB drivers use (after this patch series is merged)? That feels like a much more "sane" way to handle the wide-open debugfs namespace. Yes, there are no rules when it comes to debugfs file names and locations, but let's try to be sane please. thanks, greg k-h