From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 44948C432C3 for ; Thu, 14 Nov 2019 03:21:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5C7C1206F6 for ; Thu, 14 Nov 2019 03:21:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573701685; bh=FmT+xIiI8fjMzRISC6E96FWJYAdkxpETep6dx0aAOFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ArebEse/PEU80LMjlM5D9wpvkO0cOWECTfKq6W720BAWXpEw9f4Xvbq4S3EnwFlJr nXlK3SdxL3zddmgPbmnE3d/E0jFQFFRLC5/q9y6F6Ctd/rcsUqKCnfz00DanI3mk+M LmDGbG5wD0OfTGb49Svae4jQIASO9aI62hsSvW2s= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726979AbfKNDVV (ORCPT ); Wed, 13 Nov 2019 22:21:21 -0500 Received: from mail.kernel.org ([198.145.29.99]:59584 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726491AbfKNDVV (ORCPT ); Wed, 13 Nov 2019 22:21:21 -0500 Received: from localhost (unknown [124.219.31.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 0FC8A206F3; Thu, 14 Nov 2019 03:21:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1573701680; bh=FmT+xIiI8fjMzRISC6E96FWJYAdkxpETep6dx0aAOFQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=2ZZqboLMJesjq8BgSJ7MoVJfF7TgnYS/cpHL36P4jLxMYovM+i28jf1w3HevubntO CeDfpE3nKYFUIcb2Vwhkjbuo4IYsEvU7SVWvJfBdlElMiMJ5CCs+VgGXsWTotdq/qS w53jwTQdO8muQEOIrztPV0CPbjIZ2Oh5POjkNcYQ= Date: Thu, 14 Nov 2019 11:21:17 +0800 From: Greg Kroah-Hartman To: Chunfeng Yun Cc: Felipe Balbi , Laurent Pinchart , Mauro Carvalho Chehab , Peter Chen , Minas Harutyunyan , Cristian Birsan , Nicolas Ferre , Alexandre Belloni , Ludovic Desroches , Kevin Cernekee , Florian Fainelli , bcm-kernel-feedback-list@broadcom.com, Daniel Mack , Haojian Zhuang , Robert Jarzmik , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Bin Liu , Matthias Brugger , Stephen Boyd , Yoshihiro Shimoda , Colin Ian King , Biju Das , Fabrizio Castro , "Gustavo A. R. Silva" , Yangtao Li , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org Subject: Re: [PATCH v2 12/13] usb: gadget: udc: gr_udc: create debugfs directory under usb root Message-ID: <20191114032117.GA130252@kroah.com> References: <1573541519-28488-1-git-send-email-chunfeng.yun@mediatek.com> <1573541519-28488-12-git-send-email-chunfeng.yun@mediatek.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1573541519-28488-12-git-send-email-chunfeng.yun@mediatek.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Nov 12, 2019 at 02:51:58PM +0800, Chunfeng Yun wrote: > Now the USB gadget subsystem can use the USB debugfs root directory, > so move it's directory from the root of the debugfs filesystem into > the root of usb > > Signed-off-by: Chunfeng Yun > --- > v2: > 1. abandon new API usb_debugfs_create_dir(), and use usb_debug_root > --- > drivers/usb/gadget/udc/gr_udc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/usb/gadget/udc/gr_udc.c b/drivers/usb/gadget/udc/gr_udc.c > index 7a0e9a58c2d8..5faa09a6c770 100644 > --- a/drivers/usb/gadget/udc/gr_udc.c > +++ b/drivers/usb/gadget/udc/gr_udc.c > @@ -208,7 +208,7 @@ static void gr_dfs_create(struct gr_udc *dev) > { > const char *name = "gr_udc_state"; > > - dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), NULL); > + dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); > debugfs_create_file(name, 0444, dev->dfs_root, dev, &gr_dfs_fops); > } > This breaks the build: drivers/usb/gadget/udc/gr_udc.c: In function ‘gr_dfs_create’: drivers/usb/gadget/udc/gr_udc.c:211:57: error: ‘usb_debug_root’ undeclared (first use in this function) 211 | dev->dfs_root = debugfs_create_dir(dev_name(dev->dev), usb_debug_root); | ^~~~~~~~~~~~~~ drivers/usb/gadget/udc/gr_udc.c:211:57: note: each undeclared identifier is reported only once for each function it appears in make[4]: *** [scripts/Makefile.build:265: drivers/usb/gadget/udc/gr_udc.o] Error 1 so I've dropped it from the patch series. Please fix up and resend. And of course, always test-build your patches before you send them out... greg k-h