From: Bin Liu <b-liu@ti.com>
To: Roger Quadros <rogerq@ti.com>
Cc: <linux-usb@vger.kernel.org>, Felipe Balbi <balbi@kernel.org>
Subject: Re: [PATCH] usb: dwc3: turn off VBUS when leaving host mode
Date: Thu, 14 Nov 2019 08:16:46 -0600 [thread overview]
Message-ID: <20191114141646.GA12511@uda0271908> (raw)
In-Reply-To: <b354e1bf-6824-ccb1-9b8b-7b54b0e8fc2b@ti.com>
Roger,
On Thu, Nov 14, 2019 at 10:48:36AM +0200, Roger Quadros wrote:
> Bin,
>
> On 13/11/2019 16:15, Bin Liu wrote:
> > VBUS should be turned off when leaving the host mode.
> > Set GCTL_PRTCAP to device mode in teardown to de-assert DRVVBUS pin to
> > turn off VBUS power.
>
> Doesn't DRVVBUS pin de-assert when root hub driver turns off port power?
> Which should happen when XHCI host driver is unregistered as part of
> dwc3_host_exit()?
No, DRVVBUS is still 3.3v after 'modprbe -r dwc3-omap' on TI AM57x
platform if this patch is not applied.
-Bin.
next prev parent reply other threads:[~2019-11-14 14:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 14:15 [PATCH] usb: dwc3: turn off VBUS when leaving host mode Bin Liu
2019-11-14 8:48 ` Roger Quadros
2019-11-14 14:16 ` Bin Liu [this message]
2019-11-18 7:07 ` Felipe Balbi
2019-11-18 9:51 ` Roger Quadros
2019-12-02 7:41 ` Felipe Balbi
2019-12-09 17:15 ` Bin Liu
2019-12-10 11:50 ` Felipe Balbi
2019-12-10 13:48 ` Bin Liu
2019-12-11 14:41 ` Felipe Balbi
2019-12-11 16:10 ` [PATCH v2] " Bin Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191114141646.GA12511@uda0271908 \
--to=b-liu@ti.com \
--cc=balbi@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).