From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8A182C432C3 for ; Thu, 14 Nov 2019 14:14:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 51B3D2070E for ; Thu, 14 Nov 2019 14:14:32 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=ti.com header.i=@ti.com header.b="j6pehdzJ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726655AbfKNOOb (ORCPT ); Thu, 14 Nov 2019 09:14:31 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:36228 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726592AbfKNOOb (ORCPT ); Thu, 14 Nov 2019 09:14:31 -0500 Received: from fllv0034.itg.ti.com ([10.64.40.246]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id xAEEETNE111248; Thu, 14 Nov 2019 08:14:29 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1573740869; bh=FfrMIO/6+nKB1SAki+6rB3q2peAlKUicar9ZnEY2xvk=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=j6pehdzJgmdogSMbqRRuwfIck1Jts4Rg0bwMRcgmE+uGXcm9XTayI5xKeM01VdOhz pLv/M6mxt66ElVQ75MlW2G7powtKOahJVBdPfpuWZWtF1s5J+Jxt2pU6vXtPYBtf8L S9Sisac3/F5C8HiKMsqXZvfuW8wjObxgzR5TPV10= Received: from DFLE103.ent.ti.com (dfle103.ent.ti.com [10.64.6.24]) by fllv0034.itg.ti.com (8.15.2/8.15.2) with ESMTPS id xAEEET8d080186 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Thu, 14 Nov 2019 08:14:29 -0600 Received: from DFLE105.ent.ti.com (10.64.6.26) by DFLE103.ent.ti.com (10.64.6.24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Thu, 14 Nov 2019 08:14:29 -0600 Received: from lelv0327.itg.ti.com (10.180.67.183) by DFLE105.ent.ti.com (10.64.6.26) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Thu, 14 Nov 2019 08:14:29 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0327.itg.ti.com (8.15.2/8.15.2) with ESMTP id xAEEET0n115961; Thu, 14 Nov 2019 08:14:29 -0600 Date: Thu, 14 Nov 2019 08:16:46 -0600 From: Bin Liu To: Roger Quadros CC: , Felipe Balbi Subject: Re: [PATCH] usb: dwc3: turn off VBUS when leaving host mode Message-ID: <20191114141646.GA12511@uda0271908> Mail-Followup-To: Bin Liu , Roger Quadros , linux-usb@vger.kernel.org, Felipe Balbi References: <20191113141521.1696-1-b-liu@ti.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Roger, On Thu, Nov 14, 2019 at 10:48:36AM +0200, Roger Quadros wrote: > Bin, > > On 13/11/2019 16:15, Bin Liu wrote: > > VBUS should be turned off when leaving the host mode. > > Set GCTL_PRTCAP to device mode in teardown to de-assert DRVVBUS pin to > > turn off VBUS power. > > Doesn't DRVVBUS pin de-assert when root hub driver turns off port power? > Which should happen when XHCI host driver is unregistered as part of > dwc3_host_exit()? No, DRVVBUS is still 3.3v after 'modprbe -r dwc3-omap' on TI AM57x platform if this patch is not applied. -Bin.