From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Andrey Konovalov <andreyknvl@google.com>
Cc: USB list <linux-usb@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
Jonathan Corbet <corbet@lwn.net>, Felipe Balbi <balbi@kernel.org>,
Dmitry Vyukov <dvyukov@google.com>,
Alexander Potapenko <glider@google.com>,
Marco Elver <elver@google.com>
Subject: Re: [PATCH 1/1] usb: gadget: add raw-gadget interface
Date: Fri, 15 Nov 2019 11:20:30 +0800 [thread overview]
Message-ID: <20191115032030.GB793701@kroah.com> (raw)
In-Reply-To: <CAAeHK+y1O39gX5wDtF2j4jzpqKT8Z2c6cCHnZrh4hGWTS2Y65w@mail.gmail.com>
On Thu, Nov 14, 2019 at 04:33:56PM +0100, Andrey Konovalov wrote:
> On Thu, Nov 14, 2019 at 4:08 PM Andrey Konovalov <andreyknvl@google.com> wrote:
> > On Fri, Nov 8, 2019 at 10:17 PM Greg Kroah-Hartman
> > <gregkh@linuxfoundation.org> wrote:
> > > > +static void gadget_reset(struct usb_gadget *gadget)
> > > > +{
> > > > + pr_debug("ignoring\n");
> > > > +}
> > >
> > > I think you don't even need functions for these, right? If not, just
> > > remove. If you do, we should fix the gadget core to not require them :)
> >
> > Will do in v2.
>
> Actually, I just hit that Dummy HCD/UDC requires a disconnect callback
> to be present. And I assume other UDCs might do the same, so I'd
> rather include the callbacks just in case. WDYT?
If they require it to be present then yes, leave all of these.
thanks,
greg k-h
next prev parent reply other threads:[~2019-11-15 3:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 18:26 [PATCH 0/1] usb: gadget: add raw-gadget interface Andrey Konovalov
2019-11-08 18:26 ` [PATCH 1/1] " Andrey Konovalov
2019-11-08 21:17 ` Greg Kroah-Hartman
2019-11-08 22:17 ` Andrey Konovalov
2019-11-14 15:08 ` Andrey Konovalov
2019-11-14 15:33 ` Andrey Konovalov
2019-11-15 3:20 ` Greg Kroah-Hartman [this message]
2019-11-15 3:19 ` Greg Kroah-Hartman
2019-11-08 21:45 ` [PATCH 0/1] " Alan Stern
2019-11-08 22:18 ` Andrey Konovalov
2019-11-14 15:10 ` Andrey Konovalov
2019-11-14 15:56 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191115032030.GB793701@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=andreyknvl@google.com \
--cc=balbi@kernel.org \
--cc=corbet@lwn.net \
--cc=dvyukov@google.com \
--cc=elver@google.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).