From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC5AFC43603 for ; Mon, 9 Dec 2019 10:34:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8263E2077B for ; Mon, 9 Dec 2019 10:34:41 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fuRB4N00" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727534AbfLIKek (ORCPT ); Mon, 9 Dec 2019 05:34:40 -0500 Received: from mail-lf1-f68.google.com ([209.85.167.68]:37666 "EHLO mail-lf1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727421AbfLIKej (ORCPT ); Mon, 9 Dec 2019 05:34:39 -0500 Received: by mail-lf1-f68.google.com with SMTP id b15so10279248lfc.4 for ; Mon, 09 Dec 2019 02:34:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=64DqL3IzZjciHWWJLUTKeX5nAWdg61GDZhAuYNVZBxE=; b=fuRB4N00AOC2wnGfYA8ZaE+p3L4uglqU+9qEosyU3UoYWjG96QQSfjWspVo5HfH7tl G3+2KoQ1RS0P632vlbP8gdxLL7t3ypFeaqF0Lr8S03/XPkcwG74SQGnJF6zgfDmxQ+1B y6EI6yW8KhH36xcebyHpwPv41kZ4kHf/ujteO6oFT9X7dqQfuoSVRkGFF/YQ7zFgZAGb CXMun9LpnIPr8DQVFSFVPOFYRS17cQx+18TgkIVMYvAMfYob2nYRarWh5W5Ys7E5WAAi d9qEyjcn7Eko6+dEWGMPllm2hVgk4uonmM+Dh2UX7qz+ozHQXTWn480Q5Y5pBp0e1qSE 4XQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:mime-version :content-disposition:user-agent; bh=64DqL3IzZjciHWWJLUTKeX5nAWdg61GDZhAuYNVZBxE=; b=JHCHW8Kd5uRH5dTaMzy9gpNLgX4hwLY4PHoYQhp+Yv3zumPdUlrS6PJdLh2tCbicDe AMpl592LAY9gsNYG6NxKQhzVF5iKXcBIBRoBK9AOuQH90Usz5IHEn60CaBnP+Qpsbhwb zAfS2p6kHsPKEw/EJAwKJpghl5gEnI/OWw1+kWhUWHgOOGrgEjMEzHztuKz/ng07OvKe yiGfp4O9w6dvkuSlX6QCPLcYEhoBDqtXT2SLfEo4ZZy1E9XK/kYew9FNsD5HTcpnZw0N jFrJqEXow/o9cayDzEGt8C1rSXM9/XHsmh9ukUg0o2PIlCpaGI1aTolO0CooJbbqkZSv DQ6A== X-Gm-Message-State: APjAAAVwuVSxijDlDvIYb8v1EnvyD+wzcz+0HdcdKyo1aC+4KTmgoyNm gJTpKY6pkjQ184f5p+iUMbV7RjWW X-Google-Smtp-Source: APXvYqwbmEOV4AJZPHFhJ2jiOCulHhkqHTmsdlP7FMayUMfBGVRlEjvDDoKvkd73K4N3sa9UgrF12w== X-Received: by 2002:ac2:5337:: with SMTP id f23mr1864639lfh.192.1575887677598; Mon, 09 Dec 2019 02:34:37 -0800 (PST) Received: from google.com ([2620:0:1043:12:60fa:1524:8dd0:6d]) by smtp.gmail.com with ESMTPSA id s16sm5221396lfc.35.2019.12.09.02.34.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 09 Dec 2019 02:34:36 -0800 (PST) Date: Mon, 9 Dec 2019 11:34:35 +0100 From: Lionel Koenig To: linux-usb@vger.kernel.org Cc: Felipe Balbi , Takashi Iwai , Jonas Stenvall Subject: [PATCH] USB: gadget: u_audio: Initialize capture memory Message-ID: <20191209103435.GA55498@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org Using USB audio gadget in capture mode with an non blocking API may result in getting uninitialized memory samples. That ensure that the memory is initialized to 0 when the stream is prepared. Signed-off-by: Lionel Koenig --- drivers/usb/gadget/function/u_audio.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_audio.c b/drivers/usb/gadget/function/u_audio.c index 7ec6a996af26..6d708494ca77 100644 --- a/drivers/usb/gadget/function/u_audio.c +++ b/drivers/usb/gadget/function/u_audio.c @@ -317,6 +317,14 @@ static int uac_pcm_open(struct snd_pcm_substream *substream) return 0; } +static int uac_pcm_prepare(struct snd_pcm_substream *substream) +{ + struct snd_pcm_runtime *runtime = substream->runtime; + + memset(runtime->dma_area, 0, runtime->dma_bytes); + return 0; +} + /* ALSA cries without these function pointers */ static int uac_pcm_null(struct snd_pcm_substream *substream) { @@ -331,7 +339,7 @@ static const struct snd_pcm_ops uac_pcm_ops = { .hw_free = uac_pcm_hw_free, .trigger = uac_pcm_trigger, .pointer = uac_pcm_pointer, - .prepare = uac_pcm_null, + .prepare = uac_pcm_prepare, }; static inline void free_ep(struct uac_rtd_params *prm, struct usb_ep *ep) -- 2.24.0.393.g34dc348eaf-goog