From: Bin Liu <b-liu@ti.com>
To: Saurav Girepunje <saurav.girepunje@gmail.com>
Cc: <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <saurav.girepunje@hotmail.com>
Subject: Re: [PATCH] usb: musb: Fix external abort on non-linefetch
Date: Wed, 11 Dec 2019 13:09:53 -0600 [thread overview]
Message-ID: <20191211190953.GH16429@iaqt7> (raw)
In-Reply-To: <20191027083616.GA13761@saurav>
Hi,
On Sun, Oct 27, 2019 at 02:06:21PM +0530, Saurav Girepunje wrote:
> While setting the usb mode from sysfs. Below error came on kernel
> version 4.19.
>
> On latest kernel vserion api name changed. Therefore API
> name and backtrace API name are different.
>
> [ 821.908066] Backtrace:
> [ 821.910695] [<bf078fc0>] (musb_default_readl [musb_hdrc]) from [<bf0af738>] (dsps_musb_set_mode+0x38/0x12c [musb_dsps])
> [ 821.922059] [<bf0af700>] (dsps_musb_set_mode [musb_dsps]) from [<bf07899c>] (musb_mode_store+0xc8/0x12c [musb_hdrc])
> [ 821.933105] r7:a0010013 r6:0000000b r5:cd79d200 r4:cb634010
> [ 821.939096] [<bf0788d4>] (musb_mode_store [musb_hdrc]) from [<c0425184>] (dev_attr_store+0x20/0x2c)
> [ 821.948593] r7:cd79d200 r6:c5abbf78 r5:00000000 r4:bf0788d4
> [ 821.954549] [<c0425164>] (dev_attr_store) from [<c0285b08>] (sysfs_kf_write+0x48/0x4c)
> [ 821.962859] r5:00000000 r4:c0425164
> [ 821.966620] [<c0285ac0>] (sysfs_kf_write) from [<c0285274>] (kernfs_fop_write+0xfc/0x1fc)
> [ 821.975200] r5:00000000 r4:cd79d080
> [ 821.978966] [<c0285178>] (kernfs_fop_write) from [<c020ec00>] (__vfs_write+0x34/0x120)
> [ 821.987280] r10:00000000 r9:0000000b r8:00000000 r7:0000000b r6:c5abbf78 r5:c0285178
> [ 821.995493] r4:cb67a3c0
> [ 821.998160] [<c020ebcc>] (__vfs_write) from [<c020fae8>] (vfs_write+0xa8/0x170)
> [ 822.005835] r9:0000000b r8:00000000 r7:c5abbf78 r6:000def80 r5:cb67a3c0 r4:0000000b
> [ 822.013969] [<c020fa40>] (vfs_write) from [<c02108d0>] (SyS_write+0x44/0x98)
> [ 822.021371] r9:0000000b r8:000def80 r7:00000000 r6:00000000 r5:cb67a3c0 r4:cb67a3c0
> [ 822.029517] [<c021088c>] (SyS_write) from [<c010d8a0>] (ret_fast_syscall+0x0/0x3c)
> [ 822.037467] r9:c5aba000 r8:c010daa8 r7:00000004 r6:b6f0ad58 r5:000def80 r4:0000000b
> [ 822.045599] Code: e1a0c00d e92dd800 e24cb004 e0801001 (e5910000)
>
> Without pm_runtime_{get,put}_sync calls in place,
> Similar issue come on "mode_show" and "vbus_store" also.
Do you really get the kernel dump on mode_show() and vbus_store()? It
shouldn't because the two functions don't access musb registers. What
platform have you tested on?
>
> fix- call pm_runtime_{get,put}_sync before reading/writing
> usb mode/vbus from sysfs.
>
> As sugguested on commit '2d15f69ed5c1c33f283e77ec161578badde33eaf'
This seems to be your private commit id. You don't have to refer to it,
including the quote below.
> Merged all the fix which reslove same bug in the same file.
> "
> commit '2d15f69ed5c1c33f283e77ec161578badde33eaf'
> Author: Saurav Girepunje <saurav.girepunje@gmail.com>
> Date: Thu Aug 8 00:05:03 2019 +0530
>
> usb: musb: Fix external abort on non-linefetch for vbus_store
>
> Without pm_runtime_{get,put}_sync calls in place, writing
> vbus value via /sys causes the error
>
> "Unhandled fault external abort on non-linefetch"
>
> On Thu, Aug 08, 2019 at 12:11:46AM +0530, Saurav Girepunje wrote:
> > Without pm_runtime_{get,put}_sync calls in place, writing
> > vbus value via /sys causes the error
> >
> > "Unhandled fault external abort on non-linefetch"
> >
> > Signed-off-by: Saurav Girepunje <saurav.girepunje@xxxxxxxxx>
>
> Thanks for the patch. Can you please merge another two similar patches
> you just sent with this one? They all fix the same bug in the same file
> so could be just in one patch.
>
> -Bin.
> "
>
> Signed-off-by: Saurav Girepunje <saurav.girepunje@gmail.com>
-Bin.
next parent reply other threads:[~2019-12-11 19:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20191027083616.GA13761@saurav>
2019-12-11 19:09 ` Bin Liu [this message]
[not found] ` <20200119060404.GA104504@google.com>
2020-02-06 19:17 ` [PATCH] usb: musb: Fix external abort on non-linefetch Bin Liu
2020-01-26 16:11 Saurav Girepunje
2020-01-26 16:18 ` Greg KH
-- strict thread matches above, loose matches on Subject: below --
2019-10-28 19:31 Saurav Girepunje
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191211190953.GH16429@iaqt7 \
--to=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=saurav.girepunje@gmail.com \
--cc=saurav.girepunje@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).