From: Tony Lindgren <tony@atomide.com>
To: Bin Liu <b-liu@ti.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-omap@vger.kernel.org,
Merlijn Wajer <merlijn@wizzup.org>, Pavel Machek <pavel@ucw.cz>,
Sebastian Reichel <sre@kernel.org>
Subject: Re: [PATCH] usb: musb: fix idling for suspend after disconnect interrupt
Date: Thu, 12 Dec 2019 09:15:49 -0800 [thread overview]
Message-ID: <20191212171549.GX35479@atomide.com> (raw)
In-Reply-To: <20191212170829.GA14499@iaqt7>
* Bin Liu <b-liu@ti.com> [191212 17:09]:
> On Thu, Dec 12, 2019 at 08:09:46AM -0800, Tony Lindgren wrote:
> > That will wake up musb waiting for further interrupts thinking it's
> > connected. But after that there are no more interrupts as the cable
> > is disconnected so we need to poll the status again.
> >
> > If we see SUSPEND before DISCONNECT, then things idle fine.
>
> Does SUSPEND always comes after DISCONNECT on omap2430, or just
> sometimes? I guess the USB connector has some issue - when DP/DM pins
> are disconnected, SUSPEND interrupt is generated; when VBUS/GND pins are
> disconnected, DISCONNECT interrupt is generated. Because DP/DM pins are
> shorter than VBUS/GND, SUSPEND should come before DISCONNECT.
No this does not always happen, but happens annoyingly often for
me to notice. Your explanation sounds good though, and also sounds
that can be affected by the wear on a micro-USB connector.
Regards,
Tony
next prev parent reply other threads:[~2019-12-12 17:15 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-26 3:41 [PATCH] usb: musb: fix idling for suspend after disconnect interrupt Tony Lindgren
2019-11-26 10:20 ` Sergei Shtylyov
2019-11-26 17:45 ` Tony Lindgren
2019-12-12 17:21 ` Bin Liu
2019-12-12 17:26 ` Tony Lindgren
2019-12-12 16:00 ` Bin Liu
2019-12-12 16:09 ` Tony Lindgren
2019-12-12 17:08 ` Bin Liu
2019-12-12 17:15 ` Tony Lindgren [this message]
2020-10-27 4:55 ` Bhushan Shah
2020-10-27 6:17 ` Tony Lindgren
2020-10-27 7:59 ` Bhushan Shah
2020-10-28 8:42 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191212171549.GX35479@atomide.com \
--to=tony@atomide.com \
--cc=b-liu@ti.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=merlijn@wizzup.org \
--cc=pavel@ucw.cz \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).