From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6699C2D0CD for ; Wed, 18 Dec 2019 05:42:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B772C24650 for ; Wed, 18 Dec 2019 05:42:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="pEEICwas" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725985AbfLRFm3 (ORCPT ); Wed, 18 Dec 2019 00:42:29 -0500 Received: from mail-pf1-f196.google.com ([209.85.210.196]:36694 "EHLO mail-pf1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725881AbfLRFm2 (ORCPT ); Wed, 18 Dec 2019 00:42:28 -0500 Received: by mail-pf1-f196.google.com with SMTP id x184so584624pfb.3 for ; Tue, 17 Dec 2019 21:42:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=xV4KfJlK4YlnhchUUwxKnteaYwdyYGzcZQcMfxQtzso=; b=pEEICwashl/t9nYsbZJNVLzXODux5zOMFmXSAptDtsF9vUIfUAI33C2FPralqEaTvY 1MlZvXRJ4hKdvSRnd4S8+a9babevrFB/uNOVs0XpWwZIZ96uuWorNIbZ3YqkN35i5qaH SPRYJrHojpcfB2XlcMwpI8elGpnb94JQJ4orUHclz5Y6aXFEPkfiISDLVxJI95F2uDeb tGy4zO4ZbaehRmteUSqEvXYKbcTGCNBMcdcHb0ez7MRkewuR7EOejC0HcZZ+8XsvUPRC pk7grQlH5jvmB3CTeiE6n5qJXboxfhhCFXe8qNNWppwOECUgyfrFu/ykxBxUSaARYREH ZH8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=xV4KfJlK4YlnhchUUwxKnteaYwdyYGzcZQcMfxQtzso=; b=mJAGC4Bw2RNyGwdw6dtiaaCc6IbcN7ioCVOKerhL/1J0Kz2dNIKtCEbdPTzyPwsRvZ m4rpFshStEcul45QhAykt/+OvcXbpPICHeze9WSXt2eSIVyywfTtSEXyusADJetYkp+Z xZP76CI0N+0La7hig6+ipYNVvM1FkQXI/OjcGmXFE4FI1fdJ7kFTXirahLSulOHWumkT CIpSQ1f0xMrqIfuZzHQgOuXygwp8hj3TuueV54fQVhTcz4S9fChXmEewwRmTUr6XoRBe tmOKMQL3brh9jayIQELfdTKf5Rqn9gLmYsY4YL5/u5WWkNRxmXLhipVmt8mXKmQK9TwE SyHw== X-Gm-Message-State: APjAAAVsc1x8PRkPweOo2WvSC8lVJOYlXR3+oFxLE1Kpg5wl/CNuhKrI Z1Vf5f6y18xCmSwWqQXjR5+jnQ== X-Google-Smtp-Source: APXvYqyWesdIIO3qxjlP7JTHe12xBW/M910oPFrSVXRrjw3E1ufF2TfARQMbp5ECnXSXj86QKLMFmg== X-Received: by 2002:a63:5d03:: with SMTP id r3mr957260pgb.306.1576647747835; Tue, 17 Dec 2019 21:42:27 -0800 (PST) Received: from yoga (104-188-17-28.lightspeed.sndgca.sbcglobal.net. [104.188.17.28]) by smtp.gmail.com with ESMTPSA id g7sm1139962pfq.33.2019.12.17.21.42.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Dec 2019 21:42:27 -0800 (PST) Date: Tue, 17 Dec 2019 21:42:24 -0800 From: Bjorn Andersson To: Marek Szyprowski Cc: linux-usb@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Greg Kroah-Hartman , Krzysztof Kozlowski , Matthias Brugger , Maxime Ripard , Chen-Yu Tsai , Andy Gross , Stefan Agner , Chunfeng Yun , Linus Walleij , Bartlomiej Zolnierkiewicz Subject: Re: [PATCH v2 2/4] ARM: dts: qcom: Correct USB3503 GPIOs polarity Message-ID: <20191218054224.GE448416@yoga> References: <20191211145054.24835-1-m.szyprowski@samsung.com> <20191211145208.24976-1-m.szyprowski@samsung.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20191211145208.24976-1-m.szyprowski@samsung.com> User-Agent: Mutt/1.12.2 (2019-09-21) Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed 11 Dec 06:52 PST 2019, Marek Szyprowski wrote: > Current USB3503 driver ignores GPIO polarity and always operates as if the > GPIO lines were flagged as ACTIVE_HIGH. Fix the polarity for the existing > USB3503 chip applications to match the chip specification and common > convention for naming the pins. The only pin, which has to be ACTIVE_LOW > is the reset pin. The remaining are ACTIVE_HIGH. This change allows later > to fix the USB3503 driver to properly use generic GPIO bindings and read > polarity from DT. > > Signed-off-by: Marek Szyprowski Acked-by: Bjorn Andersson > --- > arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > index 26160c324802..942e3a2cac35 100644 > --- a/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > +++ b/arch/arm/boot/dts/qcom-mdm9615-wp8548-mangoh-green.dts > @@ -143,7 +143,7 @@ > compatible = "smsc,usb3503a"; > reg = <0x8>; > connect-gpios = <&gpioext2 1 GPIO_ACTIVE_HIGH>; > - intn-gpios = <&gpioext2 0 GPIO_ACTIVE_LOW>; > + intn-gpios = <&gpioext2 0 GPIO_ACTIVE_HIGH>; > initial-mode = <1>; > }; > }; > -- > 2.17.1 >