Re: [usb:usb-testing 36/40] drivers/usb/host/ehci.h:767:3: error: implicit declaration of function 'writel_be'; did you mean 'writeb'?

[Krzysztof Kozlowski <krzk@kernel.org>]

On Tue, Dec 31, 2019 at 11:08:14AM +0800, kbuild test robot wrote:
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
> head:   51d22e855ea3459d4b272e46aff95de0e59e65a7
> commit: 88eaaecc44461f9fb147bf7ee6ccc6d4e9fc23e0 [36/40] usb: host: Enable compile testing for some of drivers
> config: m68k-allmodconfig (attached as .config)
> compiler: m68k-linux-gcc (GCC) 7.5.0
> reproduce:
>         wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
>         chmod +x ~/bin/make.cross
>         git checkout 88eaaecc44461f9fb147bf7ee6ccc6d4e9fc23e0
>         # save the attached .config to linux build tree
>         GCC_VERSION=7.5.0 make.cross ARCH=m68k 
> 
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
> 
> All errors (new ones prefixed by >>):
> 
>    In file included from drivers/usb/host/ehci-platform.c:37:0:
>    drivers/usb/host/ehci.h: In function 'ehci_readl':
>    drivers/usb/host/ehci.h:743:3: error: implicit declaration of function 'readl_be'; did you mean 'readsb'? [-Werror=implicit-function-declaration]
>       readl_be(regs) :
>       ^~~~~~~~
>       readsb
>    drivers/usb/host/ehci.h: In function 'ehci_writel':
> >> drivers/usb/host/ehci.h:767:3: error: implicit declaration of function 'writel_be'; did you mean 'writeb'? [-Werror=implicit-function-declaration]
>       writel_be(val, regs) :
>       ^~~~~~~~~
>       writeb
>    cc1: some warnings being treated as errors

Indeed, the USB_OCTEON_EHCI should not be compile tested on all
platforms but only these having readl_be. I'll fix it up.

Best regards,
Krzysztof

> 
> vim +767 drivers/usb/host/ehci.h
> 
> 91bc4d31e81b15 Vladimir Barinov       2007-12-30  737  
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  738  static inline unsigned int ehci_readl(const struct ehci_hcd *ehci,
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  739  		__u32 __iomem *regs)
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  740  {
> d728e327d4f86d Benjamin Herrenschmidt 2006-12-28  741  #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  742  	return ehci_big_endian_mmio(ehci) ?
> 68f50e52554a0a Al Viro                2007-02-09 @743  		readl_be(regs) :
> 68f50e52554a0a Al Viro                2007-02-09  744  		readl(regs);
> d728e327d4f86d Benjamin Herrenschmidt 2006-12-28  745  #else
> 68f50e52554a0a Al Viro                2007-02-09  746  	return readl(regs);
> d728e327d4f86d Benjamin Herrenschmidt 2006-12-28  747  #endif
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  748  }
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  749  
> feffe09f510c47 Peter Chen             2014-01-10  750  #ifdef CONFIG_SOC_IMX28
> feffe09f510c47 Peter Chen             2014-01-10  751  static inline void imx28_ehci_writel(const unsigned int val,
> feffe09f510c47 Peter Chen             2014-01-10  752  		volatile __u32 __iomem *addr)
> feffe09f510c47 Peter Chen             2014-01-10  753  {
> feffe09f510c47 Peter Chen             2014-01-10  754  	__asm__ ("swp %0, %0, [%1]" : : "r"(val), "r"(addr));
> feffe09f510c47 Peter Chen             2014-01-10  755  }
> feffe09f510c47 Peter Chen             2014-01-10  756  #else
> feffe09f510c47 Peter Chen             2014-01-10  757  static inline void imx28_ehci_writel(const unsigned int val,
> feffe09f510c47 Peter Chen             2014-01-10  758  		volatile __u32 __iomem *addr)
> feffe09f510c47 Peter Chen             2014-01-10  759  {
> feffe09f510c47 Peter Chen             2014-01-10  760  }
> feffe09f510c47 Peter Chen             2014-01-10  761  #endif
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  762  static inline void ehci_writel(const struct ehci_hcd *ehci,
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  763  		const unsigned int val, __u32 __iomem *regs)
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  764  {
> d728e327d4f86d Benjamin Herrenschmidt 2006-12-28  765  #ifdef CONFIG_USB_EHCI_BIG_ENDIAN_MMIO
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  766  	ehci_big_endian_mmio(ehci) ?
> 68f50e52554a0a Al Viro                2007-02-09 @767  		writel_be(val, regs) :
> 68f50e52554a0a Al Viro                2007-02-09  768  		writel(val, regs);
> d728e327d4f86d Benjamin Herrenschmidt 2006-12-28  769  #else
> feffe09f510c47 Peter Chen             2014-01-10  770  	if (ehci->imx28_write_fix)
> feffe09f510c47 Peter Chen             2014-01-10  771  		imx28_ehci_writel(val, regs);
> feffe09f510c47 Peter Chen             2014-01-10  772  	else
> 68f50e52554a0a Al Viro                2007-02-09  773  		writel(val, regs);
> d728e327d4f86d Benjamin Herrenschmidt 2006-12-28  774  #endif
> 083522d76662cd Benjamin Herrenschmidt 2006-12-15  775  }
> 8cd42e97bf451b Kumar Gala             2006-01-20  776  
> 
> :::::: The code at line 767 was first introduced by commit
> :::::: 68f50e52554a0a55dfe2e3fdf659ee0569d73c3f [PATCH] hci_{read,write}l() does force casts to wrong type for no reason
> 
> :::::: TO: Al Viro <viro@ftp.linux.org.uk>
> :::::: CC: Linus Torvalds <torvalds@woody.linux-foundation.org>
> 
> ---
> 0-DAY kernel test infrastructure                 Open Source Technology Center
> https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org Intel Corporation