From: Dejin Zheng <zhengdejin5@gmail.com>
To: balbi@kernel.org, gregkh@linuxfoundation.org,
stern@rowland.harvard.edu, rogerq@ti.com
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Dejin Zheng <zhengdejin5@gmail.com>
Subject: [PATCH] usb: gadget: udc: core: Warn about failed to find udc
Date: Sat, 4 Jan 2020 19:28:36 +0800 [thread overview]
Message-ID: <20200104112836.28036-1-zhengdejin5@gmail.com> (raw)
If we do not warn here, the user may not know failed to
find udc class driver because it silently fails.
Let's print a warning in that case so developers find
these problems faster.
Signed-off-by: Dejin Zheng <zhengdejin5@gmail.com>
---
drivers/usb/gadget/udc/core.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/usb/gadget/udc/core.c b/drivers/usb/gadget/udc/core.c
index 51fa614b4079..9b11046480fe 100644
--- a/drivers/usb/gadget/udc/core.c
+++ b/drivers/usb/gadget/udc/core.c
@@ -1414,6 +1414,8 @@ int usb_gadget_probe_driver(struct usb_gadget_driver *driver)
}
mutex_unlock(&udc_lock);
+ if (ret)
+ pr_warn("udc-core: couldn't find an available UDC or it's busy\n");
return ret;
found:
ret = udc_bind_to_driver(udc, driver);
--
2.17.1
next reply other threads:[~2020-01-04 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-04 11:28 Dejin Zheng [this message]
2020-01-04 11:45 ` [PATCH] usb: gadget: udc: core: Warn about failed to find udc Greg KH
2020-01-04 13:09 ` Dejin Zheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200104112836.28036-1-zhengdejin5@gmail.com \
--to=zhengdejin5@gmail.com \
--cc=balbi@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rogerq@ti.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox