From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.9 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 91CE3C33C8C for ; Mon, 6 Jan 2020 23:09:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5591D207FF for ; Mon, 6 Jan 2020 23:09:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="AYeYWIf8" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726794AbgAFXJu (ORCPT ); Mon, 6 Jan 2020 18:09:50 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:27585 "EHLO us-smtp-delivery-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726721AbgAFXJu (ORCPT ); Mon, 6 Jan 2020 18:09:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1578352189; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4yvpeUCKWQFvii1V6lPkSYNB3R9g2FXMlvIvs+njHFM=; b=AYeYWIf8rrcUn4KLRhfL5VvxUG7JSzMM4KCPtpl3K7RuO+/4xzNduJdlMHHGQjmdiCOCIw v/y/O4MP+2+9BnxvVHDngaMrdYP5LfVMECqygBy9KazlezAWPSKayJACug8GqHczpc6mBR QKRz/fOyl4wXTcYUEAaR/oG1rUXMYN8= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-170-FGQV8fGnM6OZE-jIoy_yBg-1; Mon, 06 Jan 2020 18:09:46 -0500 X-MC-Unique: FGQV8fGnM6OZE-jIoy_yBg-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 15642801E77; Mon, 6 Jan 2020 23:09:45 +0000 (UTC) Received: from suzdal.zaitcev.lan (ovpn-116-146.phx2.redhat.com [10.3.116.146]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8B5061001920; Mon, 6 Jan 2020 23:09:44 +0000 (UTC) Date: Mon, 6 Jan 2020 17:09:44 -0600 From: Pete Zaitcev To: Tomasz =?UTF-8?B?TW/FhA==?= Cc: linux-usb@vger.kernel.org, Greg Kroah-Hartman , Jonathan Corbet , Alan Stern Subject: Re: [PATCH] usbmon: Report device address assigned to USB device Message-ID: <20200106170944.03a97034@suzdal.zaitcev.lan> In-Reply-To: <20200106093724.22947-1-desowin@gmail.com> References: <20200106093724.22947-1-desowin@gmail.com> Organization: Red Hat, Inc. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, 6 Jan 2020 10:37:17 +0100 Tomasz Mo=C5=84 wrote: > Make USB device addresses match while sniffing USB communication > with usbmon and hardware USB sniffer (OpenVizsla) at the same time. > On xHCI root hubs the address is assigned by hardware and can be > different than devnum. > - unsigned char devnum; /* Device address */ > + unsigned char devaddr; /* Device address */ I think it's fine, the name of the field is not exported by a header anyway, so there's no impact. Acked-by: Pete Zaitcev -- Pete