From: Johan Hovold <johan@kernel.org>
To: Steve Markgraf <steve@steve-m.de>
Cc: linux-usb@vger.kernel.org, johan@kernel.org
Subject: Re: Regression in 5.5.0-rc6 for FL2000 USB 3.0 to VGA adapter
Date: Sun, 19 Jan 2020 14:58:11 +0100 [thread overview]
Message-ID: <20200119135811.GY2301@localhost> (raw)
In-Reply-To: <9cadc6b9-16f7-e072-abee-53ac5c143198@steve-m.de>
On Sun, Jan 19, 2020 at 12:52:40AM +0100, Steve Markgraf wrote:
> Hi list,
>
> Commit 3e4f8e21c4f27bcf30a48486b9dcc269512b79ff "USB: core: fix check
> for duplicate endpoints" is causing a regression with devices based on
> the Fresco Logic FL2000 chip, i.e. it is totally unusable.
>
> The issue was first reported on the osmocom-sdr mailing list [1] and I
> can reproduce it on my machine with 5.5.0-rc6, with rc5 everything is
> working fine. By reverting the commit mentioned above, it is working as
> well.
Thanks for the detailed report.
> When connecting the device with rc6, I see the following dmesg output:
> https://steve-m.de/files/fl2000_dmesg.txt
>
> The output of lsusb -v:
> https://steve-m.de/files/fl2000_lsusb.txt
>
> Output of the Windows tool "USB Device Tree Viewer":
> https://steve-m.de/files/fl2000_usbtreeview.txt
>
> Output of the USB-IF USB 3.0 Chapter 9 tests with a version from around
> the time the FL2000 was released to market (passing):
> https://steve-m.de/files/fl2000_chapter9.html
>
> By looking at the lsusb output, it almost seems like a descriptor
> parsing issue, that now causes trouble after introducing the duplicate
> endpoint testing.
Looks like you indeed have two interfaces (0 and 1) claiming the same
endpoints (0x01 and 0x81), so the new sanity check is working as
intended.
I just took a quick look at the libosmo-fl2k code and it appears that
you claim both interfaces but never set alternate setting 1 for
interface 0, which would enable those endpoints.
Could you see if that's all that's needed to get your application
working again?
Johan
next prev parent reply other threads:[~2020-01-19 13:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-18 23:52 Regression in 5.5.0-rc6 for FL2000 USB 3.0 to VGA adapter Steve Markgraf
2020-01-19 12:58 ` Greg KH
2020-01-19 12:59 ` Greg KH
2020-01-19 13:58 ` Johan Hovold [this message]
2020-01-19 14:48 ` Steve Markgraf
2020-01-19 15:15 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200119135811.GY2301@localhost \
--to=johan@kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=steve@steve-m.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).