* [PATCH v2 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW
@ 2020-01-20 14:05 Thomas Hebb
2020-01-20 14:05 ` [PATCH v2 2/2] usb: typec: fusb302: " Thomas Hebb
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Hebb @ 2020-01-20 14:05 UTC (permalink / raw)
To: linux-kernel
Cc: linux-stable, Thomas Hebb, Greg Kroah-Hartman, Guenter Roeck,
Heikki Krogerus, linux-usb
commit 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
didn't convert this value from mW to uW when migrating to a new
specification format like it should have.
Fixes: 4c912bff46cc ("usb: typec: wcove: Provide fwnode for the port")
Cc: linux-stable@vger.kernel.org
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
---
Changes in v2:
- Split fix into two patches
- Added stable cc
drivers/usb/typec/tcpm/wcove.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/wcove.c b/drivers/usb/typec/tcpm/wcove.c
index edc271da14f4..9b745f432c91 100644
--- a/drivers/usb/typec/tcpm/wcove.c
+++ b/drivers/usb/typec/tcpm/wcove.c
@@ -597,7 +597,7 @@ static const struct property_entry wcove_props[] = {
PROPERTY_ENTRY_STRING("try-power-role", "sink"),
PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
- PROPERTY_ENTRY_U32("op-sink-microwatt", 15000),
+ PROPERTY_ENTRY_U32("op-sink-microwatt", 15000000),
{ }
};
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:05 [PATCH v2 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Thomas Hebb
@ 2020-01-20 14:05 ` Thomas Hebb
2020-01-22 9:08 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Hebb @ 2020-01-20 14:05 UTC (permalink / raw)
To: linux-kernel
Cc: linux-stable, Thomas Hebb, Greg Kroah-Hartman, Guenter Roeck,
Hans de Goede, Heikki Krogerus, linux-usb
commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
port") didn't convert this value from mW to uW when migrating to a new
specification format like it should have.
Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
Cc: linux-stable@vger.kernel.org
Signed-off-by: Thomas Hebb <tommyhebb@gmail.com>
---
Changes in v2: None
drivers/usb/typec/tcpm/fusb302.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/usb/typec/tcpm/fusb302.c b/drivers/usb/typec/tcpm/fusb302.c
index ed8655c6af8c..b498960ff72b 100644
--- a/drivers/usb/typec/tcpm/fusb302.c
+++ b/drivers/usb/typec/tcpm/fusb302.c
@@ -1666,7 +1666,7 @@ static const struct property_entry port_props[] = {
PROPERTY_ENTRY_STRING("try-power-role", "sink"),
PROPERTY_ENTRY_U32_ARRAY("source-pdos", src_pdo),
PROPERTY_ENTRY_U32_ARRAY("sink-pdos", snk_pdo),
- PROPERTY_ENTRY_U32("op-sink-microwatt", 2500),
+ PROPERTY_ENTRY_U32("op-sink-microwatt", 2500000),
{ }
};
--
2.24.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-20 14:05 ` [PATCH v2 2/2] usb: typec: fusb302: " Thomas Hebb
@ 2020-01-22 9:08 ` Greg Kroah-Hartman
2020-01-22 9:12 ` Heikki Krogerus
0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-22 9:08 UTC (permalink / raw)
To: Thomas Hebb
Cc: linux-kernel, linux-stable, Guenter Roeck, Hans de Goede,
Heikki Krogerus, linux-usb
On Mon, Jan 20, 2020 at 06:05:41AM -0800, Thomas Hebb wrote:
> commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> port") didn't convert this value from mW to uW when migrating to a new
> specification format like it should have.
>
> Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> Cc: linux-stable@vger.kernel.org
Nit, there is no such address :)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-22 9:08 ` Greg Kroah-Hartman
@ 2020-01-22 9:12 ` Heikki Krogerus
2020-01-22 9:16 ` Greg Kroah-Hartman
0 siblings, 1 reply; 5+ messages in thread
From: Heikki Krogerus @ 2020-01-22 9:12 UTC (permalink / raw)
To: Greg Kroah-Hartman
Cc: Thomas Hebb, linux-kernel, linux-stable, Guenter Roeck,
Hans de Goede, linux-usb
On Wed, Jan 22, 2020 at 10:08:20AM +0100, Greg Kroah-Hartman wrote:
> On Mon, Jan 20, 2020 at 06:05:41AM -0800, Thomas Hebb wrote:
> > commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> > port") didn't convert this value from mW to uW when migrating to a new
> > specification format like it should have.
> >
> > Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> > Cc: linux-stable@vger.kernel.org
>
> Nit, there is no such address :)
Thomas already fixed the address in v3.
thanks,
--
heikki
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2 2/2] usb: typec: fusb302: fix "op-sink-microwatt" default that was in mW
2020-01-22 9:12 ` Heikki Krogerus
@ 2020-01-22 9:16 ` Greg Kroah-Hartman
0 siblings, 0 replies; 5+ messages in thread
From: Greg Kroah-Hartman @ 2020-01-22 9:16 UTC (permalink / raw)
To: Heikki Krogerus
Cc: Thomas Hebb, linux-kernel, linux-stable, Guenter Roeck,
Hans de Goede, linux-usb
On Wed, Jan 22, 2020 at 11:12:02AM +0200, Heikki Krogerus wrote:
> On Wed, Jan 22, 2020 at 10:08:20AM +0100, Greg Kroah-Hartman wrote:
> > On Mon, Jan 20, 2020 at 06:05:41AM -0800, Thomas Hebb wrote:
> > > commit 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the
> > > port") didn't convert this value from mW to uW when migrating to a new
> > > specification format like it should have.
> > >
> > > Fixes: 8f6244055bd3 ("usb: typec: fusb302: Always provide fwnode for the port")
> > > Cc: linux-stable@vger.kernel.org
> >
> > Nit, there is no such address :)
>
> Thomas already fixed the address in v3.
Now see that series and queued it up, thanks.
greg k-h
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-01-22 9:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-01-20 14:05 [PATCH v2 1/2] usb: typec: wcove: fix "op-sink-microwatt" default that was in mW Thomas Hebb
2020-01-20 14:05 ` [PATCH v2 2/2] usb: typec: fusb302: " Thomas Hebb
2020-01-22 9:08 ` Greg Kroah-Hartman
2020-01-22 9:12 ` Heikki Krogerus
2020-01-22 9:16 ` Greg Kroah-Hartman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).