From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8BFE5C2D0DB for ; Wed, 22 Jan 2020 13:30:31 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 616432467B for ; Wed, 22 Jan 2020 13:30:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579699831; bh=rFF9R6k/DGZmUW30gr3bVUAty7o9u1eYYaO+Lr9Mkrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=MLXIs+2l3w8CyH49f7a/TpJLd1NxUcFAp6VANn0HHLJ7Vj7Yc82CgmTlSWGRFnxgO 1TVwtSaiZE2UDqHp4gO0+09YpR7O0Uf78Um8RNlmTHmfrWydjGrTPsQzZnAR39Yc1+ R9LdHFs7uX/BOHuYJZgz8dY+QRGh94aGK9QN3ie0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729673AbgAVNaa (ORCPT ); Wed, 22 Jan 2020 08:30:30 -0500 Received: from mail.kernel.org ([198.145.29.99]:53456 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729083AbgAVNa3 (ORCPT ); Wed, 22 Jan 2020 08:30:29 -0500 Received: from localhost (unknown [84.241.205.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2B410205F4; Wed, 22 Jan 2020 13:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579699827; bh=rFF9R6k/DGZmUW30gr3bVUAty7o9u1eYYaO+Lr9Mkrw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=1s9+hYaTq9mPNWAZKnkbtgLFMKls4rLTNgxxihMXRYrxn+XtaUjMstlZ8dTJ+qsg/ VBiadds+RsZRfCIbxOgCt6f4S9b0zsxoxeGgBMaU03FK+Dcgzsvnq8wl8lQAXgPdEd gmchTEm7j814B7768ihYUgO/Oy71hJ5WvmrVHld4= Date: Wed, 22 Jan 2020 14:25:42 +0100 From: Greg KH To: Johan Hovold Cc: linux-usb@vger.kernel.org, stable Subject: Re: [PATCH 3/5] USB: serial: ir-usb: fix IrLAP framing Message-ID: <20200122132542.GC3580@kroah.com> References: <20200122101530.29176-1-johan@kernel.org> <20200122101530.29176-4-johan@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200122101530.29176-4-johan@kernel.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Jan 22, 2020 at 11:15:28AM +0100, Johan Hovold wrote: > Commit f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework") > switched to using the generic write implementation which may combine > multiple write requests into larger transfers. This can break the IrLAP > protocol where end-of-frame is determined using the USB short packet > mechanism, for example, if multiple frames are sent in rapid succession. > > Fixes: f4a4cbb2047e ("USB: ir-usb: reimplement using generic framework") > Cc: stable # 2.6.35 > Signed-off-by: Johan Hovold > --- > drivers/usb/serial/ir-usb.c | 113 +++++++++++++++++++++++++++++------- > 1 file changed, 91 insertions(+), 22 deletions(-) Ah, nice fix, sorry about that :( Reviewed-by: Greg Kroah-Hartman