From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF35DC2D0DB for ; Sun, 26 Jan 2020 16:18:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8715E20720 for ; Sun, 26 Jan 2020 16:18:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580055502; bh=mNmzdpdlN+DRC9Hv252ix7aTt4qzHeJuRD6QcUsDtBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=2Vxmv4V3MkpDAs7iKDlCedZhjcfVYQYhc+I4ECQbxM2Fyx2QsCh0uXmr70EO4ZcFI vyQDCRb5pmPVtBLIvwGcgLn+JBUrNXZGQcKneMajVsF4qi1z9VZyF1jZQvUBriz5Ac HqcAah7V7I5sOgu+ygkSTgQAonCLKnIytauUgQZg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726294AbgAZQSS (ORCPT ); Sun, 26 Jan 2020 11:18:18 -0500 Received: from mail.kernel.org ([198.145.29.99]:36462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725838AbgAZQSS (ORCPT ); Sun, 26 Jan 2020 11:18:18 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4084B2071A; Sun, 26 Jan 2020 16:18:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580055496; bh=mNmzdpdlN+DRC9Hv252ix7aTt4qzHeJuRD6QcUsDtBo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=wXsKsK20OWJ+IVPj6XWepgXw1TEJFaXaMhmVCeNtxFXU1QywMkFnlTMGCLHIRLOe6 5KcdjbdIGAa01QUgBOkKkq7Rv/60/tidUtcFZ0vPLcROoCyO9yeL3wHbEFauLbDpIw DQOEBnJ4SjsAnG0ka93XA2CN3rWjH9JymgXa50AM= Date: Sun, 26 Jan 2020 17:18:12 +0100 From: Greg KH To: Saurav Girepunje Cc: b-liu@ti.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, saurav.girepunje@hotmail.com Subject: Re: [PATCH] usb: musb: Fix external abort on non-linefetch Message-ID: <20200126161812.GA4085985@kroah.com> References: <20200126161156.GA20401@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200126161156.GA20401@google.com> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sun, Jan 26, 2020 at 09:41:56PM +0530, Saurav Girepunje wrote: > While accessing the usb mode/vbus from sysfs. Below error came on kernel > version 4.19. > > On latest kernel vserion api name changed. Therefore API > name and backtrace API names are different. > > [ 821.908066] Backtrace: > [ 821.910695] [] (musb_default_readl [musb_hdrc]) from [] (dsps_musb_set_mode+0x38/0x12c [musb_dsps]) > [ 821.922059] [] (dsps_musb_set_mode [musb_dsps]) from [] (musb_mode_store+0xc8/0x12c [musb_hdrc]) > [ 821.933105] r7:a0010013 r6:0000000b r5:cd79d200 r4:cb634010 > [ 821.939096] [] (musb_mode_store [musb_hdrc]) from [] (dev_attr_store+0x20/0x2c) > [ 821.948593] r7:cd79d200 r6:c5abbf78 r5:00000000 r4:bf0788d4 > [ 821.954549] [] (dev_attr_store) from [] (sysfs_kf_write+0x48/0x4c) > [ 821.962859] r5:00000000 r4:c0425164 > [ 821.966620] [] (sysfs_kf_write) from [] (kernfs_fop_write+0xfc/0x1fc) > [ 821.975200] r5:00000000 r4:cd79d080 > [ 821.978966] [] (kernfs_fop_write) from [] (__vfs_write+0x34/0x120) > [ 821.987280] r10:00000000 r9:0000000b r8:00000000 r7:0000000b r6:c5abbf78 r5:c0285178 > [ 821.995493] r4:cb67a3c0 > [ 821.998160] [] (__vfs_write) from [] (vfs_write+0xa8/0x170) > [ 822.005835] r9:0000000b r8:00000000 r7:c5abbf78 r6:000def80 r5:cb67a3c0 r4:0000000b > [ 822.013969] [] (vfs_write) from [] (SyS_write+0x44/0x98) > [ 822.021371] r9:0000000b r8:000def80 r7:00000000 r6:00000000 r5:cb67a3c0 r4:cb67a3c0 > [ 822.029517] [] (SyS_write) from [] (ret_fast_syscall+0x0/0x3c) > [ 822.037467] r9:c5aba000 r8:c010daa8 r7:00000004 r6:b6f0ad58 r5:000def80 r4:0000000b > [ 822.045599] Code: e1a0c00d e92dd800 e24cb004 e0801001 (e5910000) > > Without pm_runtime_{get,put}_sync calls in place, > Similar issue come on "mode_show" and "vbus_store" also. > > fix- call pm_runtime_{get,put}_sync before reading/writing > usb mode/vbus from sysfs. > > Signed-off-by: Saurav Girepunje > --- > drivers/usb/musb/musb_core.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/usb/musb/musb_core.c b/drivers/usb/musb/musb_core.c > index 5ebf30b..a1ca8380 100644 > --- a/drivers/usb/musb/musb_core.c > +++ b/drivers/usb/musb/musb_core.c > @@ -1723,9 +1723,11 @@ int musb_mailbox(enum musb_vbus_id_status status) > unsigned long flags; > int ret; > + pm_runtime_get_sync(dev); > spin_lock_irqsave(&musb->lock, flags); > ret = sprintf(buf, "%s\n", usb_otg_state_string(musb->xceiv->otg->state)); > spin_unlock_irqrestore(&musb->lock, flags); > + pm_runtime_put_sync(dev); > return ret; > } Always run checkpatch.pl on patches so that you do not get grumpy maintainers telling you to run checkpatch.pl on your patch :( (hint, you need a new line after the variable definitions...) greg k-h