From: Johan Hovold <johan@kernel.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Dan Carpenter <dan.carpenter@oracle.com>,
syzkaller <syzkaller@googlegroups.com>,
Eric Dumazet <edumazet@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Hillf Danton <hdanton@sina.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
syzbot <syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com>,
Andrey Konovalov <andreyknvl@google.com>,
ingrassia@epigenesys.com, LKML <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
syzkaller-bugs <syzkaller-bugs@googlegroups.com>
Subject: Re: [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot
Date: Fri, 31 Jan 2020 14:37:26 +0100 [thread overview]
Message-ID: <20200131133726.GE10381@localhost> (raw)
In-Reply-To: <CACT4Y+YmUBUzZQNrHZtCV-LDxvmgoJtaoPYYP9OgRpAa59qF-g@mail.gmail.com>
On Fri, Jan 31, 2020 at 12:19:39PM +0100, Dmitry Vyukov wrote:
> I see lots of people also mention panic_on_warn in the context of
> these reports. panic_on_warn here is only a red herring. It really
> does not change anything. We could remove it, but still report
> WARNINGs. But syzkaller also reports some things that don't panic
> anyway. This is really about the criteria for kernel bug vs non-bug
> (something that needs to be reported or not).
Mentioning panic_on_warn is relevant to determine whether a fix needs to
be backported or not. Some of the bugs in question are mostly benign in
the sense that they are unlikely to crash your machine, but we'd still
want them in in stable due to panic_on_warn and automatic testing.
Johan
next prev parent reply other threads:[~2020-01-31 13:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-29 12:27 WARNING in ar5523_cmd/usb_submit_urb syzbot
2020-01-31 5:06 ` [PATCH] usb: core: urb: change a dev_WARN() to dev_err() for syzbot Dan Carpenter
2020-01-31 13:30 ` Johan Hovold
2020-01-31 13:39 ` Dan Carpenter
2020-02-10 19:04 ` Greg KH
2020-02-10 21:11 ` Alan Stern
2020-02-10 21:50 ` Greg KH
2020-02-11 6:03 ` Dan Carpenter
[not found] ` <20200131090510.7112-1-hdanton@sina.com>
2020-01-31 10:16 ` Dan Carpenter
2020-01-31 11:19 ` Dmitry Vyukov
2020-01-31 13:37 ` Johan Hovold [this message]
2020-01-31 14:25 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200131133726.GE10381@localhost \
--to=johan@kernel.org \
--cc=andreyknvl@google.com \
--cc=dan.carpenter@oracle.com \
--cc=dvyukov@google.com \
--cc=edumazet@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hdanton@sina.com \
--cc=ingrassia@epigenesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=stern@rowland.harvard.edu \
--cc=syzbot+1bc2c2afd44f820a669f@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
--cc=syzkaller@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).