From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.1 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 21B60C3524D for ; Tue, 4 Feb 2020 15:04:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id ED3FA2087E for ; Tue, 4 Feb 2020 15:04:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=metanate.com header.i=@metanate.com header.b="JCj3IuAL" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727301AbgBDPEd (ORCPT ); Tue, 4 Feb 2020 10:04:33 -0500 Received: from dougal.metanate.com ([90.155.101.14]:34438 "EHLO metanate.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727282AbgBDPEc (ORCPT ); Tue, 4 Feb 2020 10:04:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=simple/simple; d=metanate.com; s=stronger; h=Content-Transfer-Encoding:Content-Type:MIME-Version:References :In-Reply-To:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=ieP8o0no7ny4dq1ZgQyoiOB7696+27Jc3q08Jbxmap0=; b=JCj3IuALSH3gV+mrcQLxCTI/wH 5a4rDIpJDUQxNv1R0TsGTTmYZievYgAHheBaJT0jt+nDgnTu0nP5qNpMat62CGzT+wblKEdOdNcUo vgR+H2g4pOU7Lyc7eArRvvzYKNzDcbcDB2unGVa1Dx2yq102ABeLSshOtu6fJsoEWdPEH+sTRxlGt FUNWZ8HLwVirukMnqq6lH7ro8zx/wRjgtASneROg1tNh4FeYH3tqICaAqrIo4XubKccdSocYzg65M CSdrsAA3N/H3DCrnjUIB1yFL4yyOpKViraO/iTsEJTHpKD8Wbqb0UywsmRTPoZjvcNMyyQcZyAhY+ loq8X/7Q==; Received: from dougal.metanate.com ([192.168.88.1] helo=donbot) by email.metanate.com with esmtpsa (TLS1.3) tls TLS_AES_256_GCM_SHA384 (Exim 4.93) (envelope-from ) id 1iyzkY-0002aq-Lk; Tue, 04 Feb 2020 15:04:26 +0000 Date: Tue, 4 Feb 2020 15:04:26 +0000 From: John Keeping To: Minas Harutyunyan Cc: Felipe Balbi , Greg Kroah-Hartman , "linux-usb@vger.kernel.org" , John Youn , "stable@vger.kernel.org" Subject: Re: [PATCH] usb: dwc2: Fix SET/CLEAR_FEATURE and GET_STATUS flows Message-ID: <20200204150426.6cd3f0b6.john@metanate.com> In-Reply-To: References: <8736dsl4u4.fsf@gmail.com> <20200204114538.12af5d84.john@metanate.com> X-Mailer: Claws Mail 3.17.4 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Authenticated: YES Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, 4 Feb 2020 11:50:12 +0000 Minas Harutyunyan wrote: > On 2/4/2020 3:45 PM, John Keeping wrote: > > On Fri, 13 Dec 2019 11:54:11 +0000 > > Minas Harutyunyan wrote: > >> On 12/10/2019 6:19 PM, Minas Harutyunyan wrote: > >>> On 12/10/2019 4:53 PM, Felipe Balbi wrote: > >>>> Minas Harutyunyan writes: > >>>> > >>>>> SET/CLEAR_FEATURE for Remote Wakeup allowance not handled correctly. > >>>>> GET_STATUS handling provided not correct data on DATA Stage. > >>>>> Issue seen when gadget's dr_mode set to "otg" mode and connected > >>>>> to MacOS. > >>>>> Both are fixed and tested using USBCV Ch.9 tests. > >>>>> > >>>>> Signed-off-by: Minas Harutyunyan > >>>> > >>>> do you want to add a Fixes tag here? > >>> > >>> Fixes: fa389a6d7726 ("usb: dwc2: gadget: Add remote_wakeup_allowed flag") > >>> > >> Got tested tag by issue reported. > >> > >> Tested-By: Jack Mitchell > >> > >> Should I resubmit patch as v2 with added "Fixes" and "Tested-by" tags. > > > > Was this patch ever picked up? I don't see it in current next. > > > Yes, it picked up by Felipe. It under testing/fixes > > https://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git/commit/?h=testing/fixes&id=6de1e301b9cf8eb023357586ab8b02edda07320b Thanks! I'll try to remember to look there next time. Sorry for the noise, John