From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A212FC35247 for ; Wed, 5 Feb 2020 21:18:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 785152082E for ; Wed, 5 Feb 2020 21:18:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580937498; bh=cw/Q+0LM9/vBqCHeBQby87XziAnC/q/ln5gJPgJs8uY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=ey/hFdv298CaiqGJRkmoQodW/aWvIyo6rv5ydtMNljJozs31A8VQsAC+91JM3ktCY MsaL0C6g5JMBqFBDltVah9N5V1zV/qJHdHiuzD1dPfbHTiSl0w1vSDwTFaS8bHo0v2 GhETilidayChFaO687TxoxGKJ16VoFS0qBM3X8dM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727104AbgBEVSP (ORCPT ); Wed, 5 Feb 2020 16:18:15 -0500 Received: from mail.kernel.org ([198.145.29.99]:36272 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727033AbgBEVSP (ORCPT ); Wed, 5 Feb 2020 16:18:15 -0500 Received: from localhost (unknown [193.117.204.200]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F3BA2082E; Wed, 5 Feb 2020 21:18:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580937494; bh=cw/Q+0LM9/vBqCHeBQby87XziAnC/q/ln5gJPgJs8uY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=fxZmdrSJHuMsidDfa1uOS3dF6qWrcd1OHMT1o9OuFBK9hKVzLWq7ojVN9lkrLp9/k cF9aetR05NynOQvt76sMmLt2xxkuh8qCkTsMdM+ed5sarRKiug2OPwj2qmL9e6pAQT NouQx1+BIg6NaqlbvNVRh2Df1uZIZd/PLtErLRgw= Date: Wed, 5 Feb 2020 21:18:12 +0000 From: Greg Kroah-Hartman To: Felipe Balbi Cc: Andrey Konovalov , USB list , LKML , Jonathan Corbet , Alan Stern , Dmitry Vyukov , Alexander Potapenko , Marco Elver Subject: Re: [PATCH v5 1/1] usb: gadget: add raw-gadget interface Message-ID: <20200205211812.GD1399643@kroah.com> References: <461a787e63a9a01d83edc563575b8585bc138e8d.1579007786.git.andreyknvl@google.com> <87ftfv7nf0.fsf@kernel.org> <87a7637ise.fsf@kernel.org> <87tv4556ke.fsf@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87tv4556ke.fsf@kernel.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Feb 05, 2020 at 06:42:41PM +0200, Felipe Balbi wrote: > > Overall, supporting O_NONBLOCK might be a useful feature for people > > who are doing something else other than fuzzing, We can account for > > potential future extensions that'll support it, so detecting > > O_NONBLOCK and returning an error for now makes sense. > > > > WDYT? > > If that's the way you want to go, that's okay. But let's, then, prepare > the code for extension later on. For example, let's add an IOCTL which > returns the "version" of the ABI. Based on that, userspace can detect > features and so on. Ick, no, no version mess. If you have a new api, just add a new ioctl and away you go, userspace can easily test for that. Don't go down the path of trying to version your api, that way never works. Trust me, been there, got the t-shirt, lived to regret it. greg k-h