linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH v1] usb: dwc3: Add ACPI support for xHCI ports
@ 2020-02-18 12:42 Andy Shevchenko
  2020-02-18 14:38 ` Felipe Balbi
  0 siblings, 1 reply; 3+ messages in thread
From: Andy Shevchenko @ 2020-02-18 12:42 UTC (permalink / raw)
  To: Felipe Balbi, linux-usb, Greg Kroah-Hartman; +Cc: Andy Shevchenko

The ACPI companion of the adapter has to be set for xHCI controller
code to read and attach the ports described in the ACPI table.
Use ACPI_COMPANION_SET macro to set this.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/usb/dwc3/host.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
index fa252870c926..86dbd012b984 100644
--- a/drivers/usb/dwc3/host.c
+++ b/drivers/usb/dwc3/host.c
@@ -1,5 +1,5 @@
 // SPDX-License-Identifier: GPL-2.0
-/**
+/*
  * host.c - DesignWare USB3 DRD Controller Host Glue
  *
  * Copyright (C) 2011 Texas Instruments Incorporated - http://www.ti.com
@@ -7,6 +7,7 @@
  * Authors: Felipe Balbi <balbi@ti.com>,
  */
 
+#include <linux/acpi.h>
 #include <linux/platform_device.h>
 
 #include "core.h"
@@ -75,6 +76,7 @@ int dwc3_host_init(struct dwc3 *dwc)
 	}
 
 	xhci->dev.parent	= dwc->dev;
+	ACPI_COMPANION_SET(&xhci->dev, ACPI_COMPANION(dwc->dev));
 
 	dwc->xhci = xhci;
 
-- 
2.25.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] usb: dwc3: Add ACPI support for xHCI ports
  2020-02-18 12:42 [PATCH v1] usb: dwc3: Add ACPI support for xHCI ports Andy Shevchenko
@ 2020-02-18 14:38 ` Felipe Balbi
  2020-02-18 15:08   ` Andy Shevchenko
  0 siblings, 1 reply; 3+ messages in thread
From: Felipe Balbi @ 2020-02-18 14:38 UTC (permalink / raw)
  To: Andy Shevchenko, linux-usb, Greg Kroah-Hartman; +Cc: Andy Shevchenko

[-- Attachment #1: Type: text/plain, Size: 746 bytes --]


Hi,

Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> The ACPI companion of the adapter has to be set for xHCI controller
> code to read and attach the ports described in the ACPI table.
> Use ACPI_COMPANION_SET macro to set this.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/usb/dwc3/host.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/dwc3/host.c b/drivers/usb/dwc3/host.c
> index fa252870c926..86dbd012b984 100644
> --- a/drivers/usb/dwc3/host.c
> +++ b/drivers/usb/dwc3/host.c
> @@ -1,5 +1,5 @@
>  // SPDX-License-Identifier: GPL-2.0
> -/**
> +/*

trailing change, at least mention it in commit log ;-)

-- 
balbi

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH v1] usb: dwc3: Add ACPI support for xHCI ports
  2020-02-18 14:38 ` Felipe Balbi
@ 2020-02-18 15:08   ` Andy Shevchenko
  0 siblings, 0 replies; 3+ messages in thread
From: Andy Shevchenko @ 2020-02-18 15:08 UTC (permalink / raw)
  To: Felipe Balbi; +Cc: linux-usb, Greg Kroah-Hartman

On Tue, Feb 18, 2020 at 04:38:16PM +0200, Felipe Balbi wrote:
> Andy Shevchenko <andriy.shevchenko@linux.intel.com> writes:

> > -/**
> > +/*
> 
> trailing change, at least mention it in commit log ;-)

I will split to two. Thanks!

-- 
With Best Regards,
Andy Shevchenko



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2020-02-18 15:08 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-02-18 12:42 [PATCH v1] usb: dwc3: Add ACPI support for xHCI ports Andy Shevchenko
2020-02-18 14:38 ` Felipe Balbi
2020-02-18 15:08   ` Andy Shevchenko

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).