From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5831DC34026 for ; Tue, 18 Feb 2020 18:33:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 37A572070B for ; Tue, 18 Feb 2020 18:33:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726352AbgBRSdr (ORCPT ); Tue, 18 Feb 2020 13:33:47 -0500 Received: from mga02.intel.com ([134.134.136.20]:39454 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726225AbgBRSdr (ORCPT ); Tue, 18 Feb 2020 13:33:47 -0500 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Feb 2020 10:33:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,456,1574150400"; d="scan'208";a="348741386" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by fmsmga001.fm.intel.com with ESMTP; 18 Feb 2020 10:33:45 -0800 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1j47gp-00382Y-Po; Tue, 18 Feb 2020 20:33:47 +0200 Date: Tue, 18 Feb 2020 20:33:47 +0200 From: Andy Shevchenko To: Sergei Shtylyov Cc: Greg Kroah-Hartman , linux-usb@vger.kernel.org Subject: Re: [PATCH v1] usb: core: Make use of acpi_evaluate_object() status Message-ID: <20200218183347.GL10400@smile.fi.intel.com> References: <20200218160954.42815-1-andriy.shevchenko@linux.intel.com> <511c8750-b188-82a1-e839-6b136e5c727c@cogentembedded.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <511c8750-b188-82a1-e839-6b136e5c727c@cogentembedded.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Tue, Feb 18, 2020 at 09:17:47PM +0300, Sergei Shtylyov wrote: > On 02/18/2020 07:09 PM, Andy Shevchenko wrote: ... > > + if (!upc || (upc->type != ACPI_TYPE_PACKAGE) || upc->package.count != 4) { > > goto out; > > } > > I'd drop {} here, while at it. Yep, makes sense, thanks! -- With Best Regards, Andy Shevchenko