From: Peter Chen <peter.chen@nxp.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: Linux PM <linux-pm@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Amit Kucheria <amit.kucheria@linaro.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>
Subject: Re: [PATCH 23/28] drivers: usb: Call cpu_latency_qos_*() instead of pm_qos_*()
Date: Wed, 19 Feb 2020 01:09:42 +0000 [thread overview]
Message-ID: <20200219010943.GA8602@b29397-desktop> (raw)
In-Reply-To: <19064076.ICumzjfW0v@kreacher>
On 20-02-12 00:28:44, Rafael J. Wysocki wrote:
> From: "Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
>
> Call cpu_latency_qos_add/remove_request() instead of
> pm_qos_add/remove_request(), respectively, because the
> latter are going to be dropped.
>
> No intentional functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> drivers/usb/chipidea/ci_hdrc_imx.c | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/usb/chipidea/ci_hdrc_imx.c b/drivers/usb/chipidea/ci_hdrc_imx.c
> index d8e7eb2f97b9..a479af3ae31d 100644
> --- a/drivers/usb/chipidea/ci_hdrc_imx.c
> +++ b/drivers/usb/chipidea/ci_hdrc_imx.c
> @@ -393,8 +393,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> }
>
> if (pdata.flags & CI_HDRC_PMQOS)
> - pm_qos_add_request(&data->pm_qos_req,
> - PM_QOS_CPU_DMA_LATENCY, 0);
> + cpu_latency_qos_add_request(&data->pm_qos_req, 0);
>
> ret = imx_get_clks(dev);
> if (ret)
> @@ -478,7 +477,7 @@ static int ci_hdrc_imx_probe(struct platform_device *pdev)
> /* don't overwrite original ret (cf. EPROBE_DEFER) */
> regulator_disable(data->hsic_pad_regulator);
> if (pdata.flags & CI_HDRC_PMQOS)
> - pm_qos_remove_request(&data->pm_qos_req);
> + cpu_latency_qos_remove_request(&data->pm_qos_req);
> data->ci_pdev = NULL;
> return ret;
> }
> @@ -499,7 +498,7 @@ static int ci_hdrc_imx_remove(struct platform_device *pdev)
> if (data->ci_pdev) {
> imx_disable_unprepare_clks(&pdev->dev);
> if (data->plat_data->flags & CI_HDRC_PMQOS)
> - pm_qos_remove_request(&data->pm_qos_req);
> + cpu_latency_qos_remove_request(&data->pm_qos_req);
> if (data->hsic_pad_regulator)
> regulator_disable(data->hsic_pad_regulator);
> }
> @@ -527,7 +526,7 @@ static int __maybe_unused imx_controller_suspend(struct device *dev)
>
> imx_disable_unprepare_clks(dev);
> if (data->plat_data->flags & CI_HDRC_PMQOS)
> - pm_qos_remove_request(&data->pm_qos_req);
> + cpu_latency_qos_remove_request(&data->pm_qos_req);
>
> data->in_lpm = true;
>
> @@ -547,8 +546,7 @@ static int __maybe_unused imx_controller_resume(struct device *dev)
> }
>
> if (data->plat_data->flags & CI_HDRC_PMQOS)
> - pm_qos_add_request(&data->pm_qos_req,
> - PM_QOS_CPU_DMA_LATENCY, 0);
> + cpu_latency_qos_add_request(&data->pm_qos_req, 0);
>
> ret = imx_prepare_enable_clks(dev);
> if (ret)
> --
> 2.16.4
>
Acked-by: Peter Chen <peter.chen@nxp.com>
--
Thanks,
Peter Chen
prev parent reply other threads:[~2020-02-19 1:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1654227.8mz0SueHsU@kreacher>
2020-02-11 23:28 ` [PATCH 23/28] drivers: usb: Call cpu_latency_qos_*() instead of pm_qos_*() Rafael J. Wysocki
2020-02-12 18:38 ` Greg KH
2020-02-18 8:03 ` Peter Chen
2020-02-18 8:08 ` Greg KH
2020-02-18 8:11 ` Peter Chen
2020-02-19 1:09 ` Peter Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200219010943.GA8602@b29397-desktop \
--to=peter.chen@nxp.com \
--cc=amit.kucheria@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox