From: Johan Hovold <johan@kernel.org>
To: Tiezhu Yang <yangtiezhu@loongson.cn>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Xuefeng Li <lixuefeng@loongson.cn>
Subject: Re: [PATCH 2/2] USB: core: Fix potential memory leak in usb_get_configuration()
Date: Wed, 26 Feb 2020 09:09:06 +0100 [thread overview]
Message-ID: <20200226080906.GV32540@localhost> (raw)
In-Reply-To: <1582697723-7274-2-git-send-email-yangtiezhu@loongson.cn>
On Wed, Feb 26, 2020 at 02:15:23PM +0800, Tiezhu Yang wrote:
> Make sure to free all the allocated memory before exiting from the function
> usb_get_configuration() when an error is encountered.
There's no leak in this function as far as I can tell. Any allocated
memory is released in usb_destroy_configuration() when the last
reference to the struct usb_device is dropped.
> Additionally, just initialize the variable "bigbuffer" with NULL to avoid
> the following build warning:
>
> CC drivers/usb/core/config.o
> drivers/usb/core/config.c: In function ‘usb_get_configuration’:
> drivers/usb/core/config.c:956:2: warning: ‘bigbuffer’ may be used uninitialized in this function [-Wmaybe-uninitialized]
> kfree(bigbuffer);
> ^
No need to mention warnings that you introduce yourself while creating
your patch. It can give the false impression that your addressing an
existing issue.
Johan
next prev parent reply other threads:[~2020-02-26 8:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 6:15 [PATCH 1/2] USB: core: Fix build warning in usb_get_configuration() Tiezhu Yang
2020-02-26 6:15 ` [PATCH 2/2] USB: core: Fix potential memory leak " Tiezhu Yang
2020-02-26 8:09 ` Johan Hovold [this message]
2020-02-26 8:42 ` Tiezhu Yang
2020-02-26 10:12 ` Johan Hovold
2020-02-26 8:04 ` [PATCH 1/2] USB: core: Fix build warning " Johan Hovold
2020-02-26 8:35 ` Tiezhu Yang
2020-02-26 10:09 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226080906.GV32540@localhost \
--to=johan@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lixuefeng@loongson.cn \
--cc=yangtiezhu@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).