From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Richard Leitner <richard.leitner@skidata.com>
Cc: Marco Felsch <m.felsch@pengutronix.de>,
gregkh@linuxfoundation.org, linux-usb@vger.kernel.org,
kernel@pengutronix.de
Subject: Re: [PATCH] usb: usb251xb: check if hub is already attached
Date: Thu, 27 Feb 2020 09:41:33 +0100 [thread overview]
Message-ID: <20200227084133.spydp5fudfqc6eim@pengutronix.de> (raw)
In-Reply-To: <20200227083007.GB13758@pcleri>
Hello,
On Thu, Feb 27, 2020 at 09:30:07AM +0100, Richard Leitner wrote:
> On Thu, Feb 27, 2020 at 09:14:48AM +0100, Uwe Kleine-König wrote:
> > If you write this as:
> >
> > if (!hub->gpio_reset && usb251xb_hub_attached(hub))
> > return 0;
> >
> > you save some i2c transfers in the presence of a reset gpio.
>
> I'd also go with this solution, so you only have i2c transfers when a
> reset gpio is configured/present.
Nitpick: you only have additional i2c transfers if *no* reset gpio is
configured/present.
Best regards
Uwe
--
Pengutronix e.K. | Uwe Kleine-König |
Industrial Linux Solutions | https://www.pengutronix.de/ |
next prev parent reply other threads:[~2020-02-27 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-27 7:25 [PATCH] usb: usb251xb: check if hub is already attached Marco Felsch
2020-02-27 8:14 ` Uwe Kleine-König
2020-02-27 8:30 ` Richard Leitner
2020-02-27 8:41 ` Uwe Kleine-König [this message]
2020-02-27 9:09 ` Richard Leitner
2020-02-27 9:29 ` Marco Felsch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200227084133.spydp5fudfqc6eim@pengutronix.de \
--to=u.kleine-koenig@pengutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=kernel@pengutronix.de \
--cc=linux-usb@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=richard.leitner@skidata.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox