From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>, Jens Axboe <axboe@fb.com>,
Sagi Grimberg <sagi@grimberg.me>,
Chaitanya Kulkarni <chaitanya.kulkarni@wdc.com>,
linux-nvme@lists.infradead.org, Felipe Balbi <balbi@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org,
"Martin K. Petersen" <martin.petersen@oracle.com>,
linux-scsi@vger.kernel.org, Arnd Bergmann <arnd@arndb.de>,
linux-arch@vger.kernel.org, bvanassche@acm.org
Subject: Re: [PATCH v1] asm-generic: Provide generic {get,put}_unaligned_{l,b}e24()
Date: Thu, 12 Mar 2020 16:43:40 +0200 [thread overview]
Message-ID: <20200312144340.GV1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200312140542.GA17152@lst.de>
On Thu, Mar 12, 2020 at 03:05:42PM +0100, Christoph Hellwig wrote:
> On Thu, Mar 12, 2020 at 01:39:41PM +0200, Andy Shevchenko wrote:
> > There are users in kernel that duplicate {get,put}_unaligned_{l,b}e24()
> > implementation. Provide generic helpers once for all.
>
> I have a vague memory of Bart sending a patch like this a while ago,
> adding him to verify my theory.
Thanks!
> Also is there any good to have this in asm-generic/ vs linux/?
For now on it is least invasive. asm-generic/unaligned is a cross point for all
unaligned accessor helpers, since we here do byteshift approach for all
possible variants, I don't see any other header suitable. Or are you talking
about something like linux/unaligned/24bit.h -> #include <...> here?
--
With Best Regards,
Andy Shevchenko
next prev parent reply other threads:[~2020-03-12 14:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 11:39 [PATCH v1] asm-generic: Provide generic {get,put}_unaligned_{l,b}e24() Andy Shevchenko
2020-03-12 12:06 ` Greg Kroah-Hartman
2020-03-12 14:05 ` Christoph Hellwig
2020-03-12 14:43 ` Andy Shevchenko [this message]
2020-03-12 15:18 ` [PATCH v1] asm-generic: Provide generic {get, put}_unaligned_{l, b}e24() Bart Van Assche
2020-03-12 16:25 ` Andy Shevchenko
2020-03-12 18:50 ` Bart Van Assche
[not found] ` <CAO+b5-rXUU9r-SrCWq2cYbBr5xFqyx4CUMb8xHZv2xYzEP6CyA@mail.gmail.com>
2020-03-13 0:38 ` Martin K. Petersen
2020-03-12 15:21 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200312144340.GV1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=axboe@fb.com \
--cc=balbi@kernel.org \
--cc=bvanassche@acm.org \
--cc=chaitanya.kulkarni@wdc.com \
--cc=gregkh@linuxfoundation.org \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-arch@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).