From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4BEE3C1975A for ; Thu, 12 Mar 2020 14:43:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 267EB2071C for ; Thu, 12 Mar 2020 14:43:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727736AbgCLOnn (ORCPT ); Thu, 12 Mar 2020 10:43:43 -0400 Received: from mga05.intel.com ([192.55.52.43]:17696 "EHLO mga05.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727602AbgCLOnn (ORCPT ); Thu, 12 Mar 2020 10:43:43 -0400 X-Amp-Result: UNKNOWN X-Amp-Original-Verdict: FILE UNKNOWN X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Mar 2020 07:43:42 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.70,545,1574150400"; d="scan'208";a="246391848" Received: from smile.fi.intel.com (HELO smile) ([10.237.68.40]) by orsmga006.jf.intel.com with ESMTP; 12 Mar 2020 07:43:38 -0700 Received: from andy by smile with local (Exim 4.93) (envelope-from ) id 1jCP3k-0090m7-Jt; Thu, 12 Mar 2020 16:43:40 +0200 Date: Thu, 12 Mar 2020 16:43:40 +0200 From: Andy Shevchenko To: Christoph Hellwig Cc: Keith Busch , Jens Axboe , Sagi Grimberg , Chaitanya Kulkarni , linux-nvme@lists.infradead.org, Felipe Balbi , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "Martin K. Petersen" , linux-scsi@vger.kernel.org, Arnd Bergmann , linux-arch@vger.kernel.org, bvanassche@acm.org Subject: Re: [PATCH v1] asm-generic: Provide generic {get,put}_unaligned_{l,b}e24() Message-ID: <20200312144340.GV1922688@smile.fi.intel.com> References: <20200312113941.81162-1-andriy.shevchenko@linux.intel.com> <20200312140542.GA17152@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200312140542.GA17152@lst.de> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Thu, Mar 12, 2020 at 03:05:42PM +0100, Christoph Hellwig wrote: > On Thu, Mar 12, 2020 at 01:39:41PM +0200, Andy Shevchenko wrote: > > There are users in kernel that duplicate {get,put}_unaligned_{l,b}e24() > > implementation. Provide generic helpers once for all. > > I have a vague memory of Bart sending a patch like this a while ago, > adding him to verify my theory. Thanks! > Also is there any good to have this in asm-generic/ vs linux/? For now on it is least invasive. asm-generic/unaligned is a cross point for all unaligned accessor helpers, since we here do byteshift approach for all possible variants, I don't see any other header suitable. Or are you talking about something like linux/unaligned/24bit.h -> #include <...> here? -- With Best Regards, Andy Shevchenko