* [PATCH 0/2] Avoid multiple line dereference
@ 2020-03-20 2:03 Gokce Kuler
2020-03-20 2:03 ` [PATCH 1/2] staging: rtl8712: " Gokce Kuler
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Gokce Kuler @ 2020-03-20 2:03 UTC (permalink / raw)
To: outreachy-kernel; +Cc: linux-usb, gregkh
merge a line -> with a line ending with a sign
merge a line -> with a line ending with a sign
Gokce Kuler (2):
staging: rtl8712: Avoid multiple line dereference
staging: rtl8712: Avoid multiple line dereference
drivers/staging/rtl8712/rtl871x_mlme.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
--
2.7.4
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] staging: rtl8712: Avoid multiple line dereference
2020-03-20 2:03 [PATCH 0/2] Avoid multiple line dereference Gokce Kuler
@ 2020-03-20 2:03 ` Gokce Kuler
2020-03-20 9:19 ` Sergei Shtylyov
2020-03-20 2:03 ` [PATCH 2/2] " Gokce Kuler
2020-03-20 6:59 ` [PATCH 0/2] " Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Gokce Kuler @ 2020-03-20 2:03 UTC (permalink / raw)
To: outreachy-kernel; +Cc: linux-usb, gregkh
merge a line -> with a line ending with a sign
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index cabdb35..74dac74 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -944,8 +944,7 @@ void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf)
pdev_network = &(adapter->registrypriv.dev_network);
pibss = adapter->registrypriv.dev_network.MacAddress;
memcpy(pdev_network, &tgt_network->network,
- r8712_get_wlan_bssid_ex_sz(&tgt_network->
- network));
+ r8712_get_wlan_bssid_ex_sz(&tgt_network->network));
memcpy(&pdev_network->Ssid,
&pmlmepriv->assoc_ssid,
sizeof(struct ndis_802_11_ssid));
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] staging: rtl8712: Avoid multiple line dereference
2020-03-20 2:03 ` [PATCH 1/2] staging: rtl8712: " Gokce Kuler
@ 2020-03-20 9:19 ` Sergei Shtylyov
0 siblings, 0 replies; 6+ messages in thread
From: Sergei Shtylyov @ 2020-03-20 9:19 UTC (permalink / raw)
To: Gokce Kuler, outreachy-kernel; +Cc: linux-usb, gregkh
Hello!
On 20.03.2020 5:03, Gokce Kuler wrote:
> merge a line -> with a line ending with a sign
What sign?
> Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
> ---
> drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
> index cabdb35..74dac74 100644
> --- a/drivers/staging/rtl8712/rtl871x_mlme.c
> +++ b/drivers/staging/rtl8712/rtl871x_mlme.c
> @@ -944,8 +944,7 @@ void r8712_stadel_event_callback(struct _adapter *adapter, u8 *pbuf)
> pdev_network = &(adapter->registrypriv.dev_network);
> pibss = adapter->registrypriv.dev_network.MacAddress;
> memcpy(pdev_network, &tgt_network->network,
> - r8712_get_wlan_bssid_ex_sz(&tgt_network->
> - network));
> + r8712_get_wlan_bssid_ex_sz(&tgt_network->network));
> memcpy(&pdev_network->Ssid,
> &pmlmepriv->assoc_ssid,
> sizeof(struct ndis_802_11_ssid));
MBR, Sergei
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] staging: rtl8712: Avoid multiple line dereference
2020-03-20 2:03 [PATCH 0/2] Avoid multiple line dereference Gokce Kuler
2020-03-20 2:03 ` [PATCH 1/2] staging: rtl8712: " Gokce Kuler
@ 2020-03-20 2:03 ` Gokce Kuler
2020-03-20 6:59 ` [PATCH 0/2] " Greg KH
2 siblings, 0 replies; 6+ messages in thread
From: Gokce Kuler @ 2020-03-20 2:03 UTC (permalink / raw)
To: outreachy-kernel; +Cc: linux-usb, gregkh
merge a line -> with a line ending with a sign
Signed-off-by: Gokce Kuler <gokcekuler@gmail.com>
---
drivers/staging/rtl8712/rtl871x_mlme.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8712/rtl871x_mlme.c b/drivers/staging/rtl8712/rtl871x_mlme.c
index 74dac74..7d5a50a 100644
--- a/drivers/staging/rtl8712/rtl871x_mlme.c
+++ b/drivers/staging/rtl8712/rtl871x_mlme.c
@@ -1094,8 +1094,7 @@ int r8712_select_and_join_from_scan(struct mlme_priv *pmlmepriv)
src_ssid = pmlmepriv->assoc_bssid;
if (!memcmp(dst_ssid, src_ssid, ETH_ALEN)) {
if (check_fwstate(pmlmepriv, _FW_LINKED)) {
- if (is_same_network(&pmlmepriv->
- cur_network.network,
+ if (is_same_network(&pmlmepriv->cur_network.network,
&pnetwork->network)) {
_clr_fwstate_(pmlmepriv,
_FW_UNDER_LINKING);
--
2.7.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 0/2] Avoid multiple line dereference
2020-03-20 2:03 [PATCH 0/2] Avoid multiple line dereference Gokce Kuler
2020-03-20 2:03 ` [PATCH 1/2] staging: rtl8712: " Gokce Kuler
2020-03-20 2:03 ` [PATCH 2/2] " Gokce Kuler
@ 2020-03-20 6:59 ` Greg KH
2020-03-20 6:59 ` Greg KH
2 siblings, 1 reply; 6+ messages in thread
From: Greg KH @ 2020-03-20 6:59 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, linux-usb
On Fri, Mar 20, 2020 at 05:03:03AM +0300, Gokce Kuler wrote:
> merge a line -> with a line ending with a sign
>
> merge a line -> with a line ending with a sign
>
> Gokce Kuler (2):
> staging: rtl8712: Avoid multiple line dereference
> staging: rtl8712: Avoid multiple line dereference
You should put the subsystem and driver in this 0/2 email subject as
well.
But the big problem of this (have you been reading other patch
submissions here?) is that you sent 2 patches that did different things,
yet had the same subject line, which is not ok.
Please make them unique.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 0/2] Avoid multiple line dereference
2020-03-20 6:59 ` [PATCH 0/2] " Greg KH
@ 2020-03-20 6:59 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2020-03-20 6:59 UTC (permalink / raw)
To: Gokce Kuler; +Cc: outreachy-kernel, linux-usb
On Fri, Mar 20, 2020 at 07:59:06AM +0100, Greg KH wrote:
> On Fri, Mar 20, 2020 at 05:03:03AM +0300, Gokce Kuler wrote:
> > merge a line -> with a line ending with a sign
> >
> > merge a line -> with a line ending with a sign
> >
> > Gokce Kuler (2):
> > staging: rtl8712: Avoid multiple line dereference
> > staging: rtl8712: Avoid multiple line dereference
>
> You should put the subsystem and driver in this 0/2 email subject as
> well.
>
> But the big problem of this (have you been reading other patch
> submissions here?) is that you sent 2 patches that did different things,
> yet had the same subject line, which is not ok.
>
> Please make them unique.
And why is this 2 patches anyway? SHouldn't it just be 1 patch as you
are doing 1 logical thing to the file?
Do not make multiple patches were a single one is all that is needed.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-03-20 9:19 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-03-20 2:03 [PATCH 0/2] Avoid multiple line dereference Gokce Kuler
2020-03-20 2:03 ` [PATCH 1/2] staging: rtl8712: " Gokce Kuler
2020-03-20 9:19 ` Sergei Shtylyov
2020-03-20 2:03 ` [PATCH 2/2] " Gokce Kuler
2020-03-20 6:59 ` [PATCH 0/2] " Greg KH
2020-03-20 6:59 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).