From: Vinod Koul <vkoul@kernel.org>
To: kbuild test robot <lkp@intel.com>
Cc: kbuild-all@lists.01.org, clang-built-linux@googlegroups.com,
"Mathias Nyman" <mathias.nyman@intel.com>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"linux-arm-msm@vger.kernel.org,
Bjorn Andersson" <bjorn.andersson@linaro.org>,
"Yoshihiro Shimoda" <yoshihiro.shimoda.uh@renesas.com>,
"Christian Lamparter" <chunkeey@googlemail.com>,
"John Stultz" <john.stultz@linaro.org>,
"Alan Stern" <stern@rowland.harvard.edu>,
"Andreas Böhler" <dev@aboehler.at>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
"Mathias Nyman" <mathias.nyman@linux.intel.com>
Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe
Date: Mon, 23 Mar 2020 21:04:29 +0530 [thread overview]
Message-ID: <20200323153429.GR72691@vkoul-mobl> (raw)
In-Reply-To: <202003232207.IGeWbiPn%lkp@intel.com>
On 23-03-20, 22:49, kbuild test robot wrote:
> Hi Vinod,
>
> I love your patch! Yet something to improve:
Thanks for the report.
> [auto build test ERROR on v5.6-rc7]
> [also build test ERROR on next-20200323]
> [cannot apply to usb/usb-testing]
> [if your patch is applied to the wrong git tree, please drop us a note to help
> improve the system. BTW, we also suggest to use '--base' option to specify the
> base tree in git format-patch, please see https://stackoverflow.com/a/37406982]
>
> url: https://github.com/0day-ci/linux/commits/Vinod-Koul/usb-xhci-Add-support-for-Renesas-USB-controllers/20200323-203447
> base: 16fbf79b0f83bc752cee8589279f1ebfe57b3b6e
> config: x86_64-defconfig (attached as .config)
> compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 006244152d6c7dd6a390ff89b236cc7801834b46)
> reproduce:
> wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
> chmod +x ~/bin/make.cross
> # save the attached .config to linux build tree
> COMPILER=clang make.cross ARCH=x86_64
>
> If you fix the issue, kindly add following tag
> Reported-by: kbuild test robot <lkp@intel.com>
>
> All errors (new ones prefixed by >>):
>
> In file included from drivers/usb/host/uhci-hcd.c:847:
> >> drivers/usb/host/uhci-pci.c:297:36: error: passing 'const struct hc_driver *' to parameter of type 'struct hc_driver *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
> return usb_hcd_pci_probe(dev, id, &uhci_driver);
> ^~~~~~~~~~~~
> include/linux/usb/hcd.h:483:27: note: passing argument to parameter 'driver' here
> struct hc_driver *driver);
I need to drop the const qualifiers for uhci_driver, I have checked that
and will send v8 with this fix
--
~Vinod
next prev parent reply other threads:[~2020-03-23 15:34 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-23 10:11 [PATCH v7 0/5] usb: xhci: Add support for Renesas USB controllers Vinod Koul
2020-03-23 10:11 ` [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe Vinod Koul
2020-03-23 14:49 ` kbuild test robot
2020-03-23 15:34 ` Vinod Koul [this message]
2020-03-23 15:48 ` Alan Stern
2020-03-23 16:11 ` Vinod Koul
2020-03-23 15:25 ` Alan Stern
2020-03-23 15:37 ` Vinod Koul
2020-03-23 19:30 ` kbuild test robot
2020-03-23 10:11 ` [PATCH v7 2/5] usb: renesas-xhci: Add the renesas xhci driver Vinod Koul
2020-03-23 10:11 ` [PATCH v7 3/5] usb: xhci: Add support for Renesas controller with memory Vinod Koul
2020-03-23 10:11 ` [PATCH v7 4/5] usb: renesas-xhci: Add ROM loader for uPD720201 Vinod Koul
2020-03-23 10:11 ` [PATCH v7 5/5] usb: xhci: provide a debugfs hook for erasing rom Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200323153429.GR72691@vkoul-mobl \
--to=vkoul@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=chunkeey@googlemail.com \
--cc=clang-built-linux@googlegroups.com \
--cc=dev@aboehler.at \
--cc=gregkh@linuxfoundation.org \
--cc=john.stultz@linaro.org \
--cc=kbuild-all@lists.01.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathias.nyman@intel.com \
--cc=mathias.nyman@linux.intel.com \
--cc=stern@rowland.harvard.edu \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox