From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86477C3F2CD for ; Mon, 23 Mar 2020 15:37:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5DC9920637 for ; Mon, 23 Mar 2020 15:37:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584977874; bh=Z1yjbVFwxDTH5lTh08p7g0JLlUyFhwayQGE31XdVD7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=EBr47F5Ou35MsbyuJ1OkpOGbAf/ZH6zv5Agc1Uo7HjpLvCvz2JT6T0nwOjH7ofnMh IoDXIyE/CHypTIIZmCg7ejDWxE1yyqq/oHKJ7jpCGQFbmxMY9IWArRaUQg7bi/qNeh LASCiiehhBS8TpPOJEg2D+5x75RUSAARXt/SFYKs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727240AbgCWPhu (ORCPT ); Mon, 23 Mar 2020 11:37:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:40124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727124AbgCWPhu (ORCPT ); Mon, 23 Mar 2020 11:37:50 -0400 Received: from localhost (unknown [122.178.205.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 2EC1620409; Mon, 23 Mar 2020 15:37:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584977870; bh=Z1yjbVFwxDTH5lTh08p7g0JLlUyFhwayQGE31XdVD7s=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=NRwSWuNaEXXHgbpIv+3/grL4Qx5XL6lo+vRXPdldT2ZAyJcWVj0TnV1+XBrK+2ROC PTehIk29EUxTlA5bMGp3Hg7briNH+d5f0g+dNEFcGYy6LiDfpfdEcBnL00ujEXY+Qw RA3gpSR1/PzAFn6uyamfQ9CeEWXNNJHhLMZbfDgg= Date: Mon, 23 Mar 2020 21:07:45 +0530 From: Vinod Koul To: Alan Stern Cc: Mathias Nyman , Greg Kroah-Hartman , linux-arm-msm@vger.kernel.org, Bjorn Andersson , Yoshihiro Shimoda , Christian Lamparter , John Stultz , Andreas =?iso-8859-1?Q?B=F6hler?= , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Mathias Nyman Subject: Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe Message-ID: <20200323153745.GS72691@vkoul-mobl> References: <20200323101121.243906-2-vkoul@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On 23-03-20, 11:25, Alan Stern wrote: > On Mon, 23 Mar 2020, Vinod Koul wrote: > > > usb_hcd_pci_probe expects users to call this with driver_data set as > > hc_driver, that limits the possibility of using the driver_data for > > driver data. > > > > Add hc_driver as argument to usb_hcd_pci_probe and modify the callers > > ehci/ohci/xhci/uhci to pass hc_driver as argument and freeup the > > driver_data used > > > > Tested xhci driver on Dragon-board RB3, compile tested ehci and ohci. > > Couldn't compile uhci > > > > Suggested-by: Mathias Nyman > > Signed-off-by: Vinod Koul > > --- > > drivers/usb/core/hcd-pci.c | 7 ++++--- > > drivers/usb/host/ehci-pci.c | 6 ++---- > > drivers/usb/host/ohci-pci.c | 9 ++++++--- > > drivers/usb/host/uhci-pci.c | 8 ++++++-- > > drivers/usb/host/xhci-pci.c | 14 +++++--------- > > include/linux/usb/hcd.h | 3 ++- > > 6 files changed, 25 insertions(+), 22 deletions(-) > > For all but the xHCI parts: > > Acked-by: Alan Stern Alan, Thanks for the quick ack. I will send v8 with your ack on first patch (that touches *hci ) Thanks -- ~Vinod