Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe

Vinod Koul
2020-03-23T15:37:54Z

On 23-03-20, 11:25, Alan Stern wrote:
> On Mon, 23 Mar 2020, Vinod Koul wrote:
>
> > usb_hcd_pci_probe expects users to call this with driver_data set as
> > hc_driver, that limits the possibility of using the driver_data for
> > driver data.
> >
> > Add hc_driver as argument to usb_hcd_pci_probe and modify the callers
> > ehci/ohci/xhci/uhci to pass hc_driver as argument and freeup the
> > driver_data used
> >
> > Tested xhci driver on Dragon-board RB3, compile tested ehci and ohci.
> > Couldn't compile uhci
> >
> > Suggested-by: Mathias Nyman <mathias.nyman@linux.intel.com>
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
> > ---
> > drivers/usb/core/hcd-pci.c | 7 ++++---
> > drivers/usb/host/ehci-pci.c | 6 ++----
> > drivers/usb/host/ohci-pci.c | 9 ++++++---
> > drivers/usb/host/uhci-pci.c | 8 ++++++--
> > drivers/usb/host/xhci-pci.c | 14 +++++---------
> > include/linux/usb/hcd.h | 3 ++-
> > 6 files changed, 25 insertions(+), 22 deletions(-)
>
> For all but the xHCI parts:
>
> Acked-by: Alan Stern <stern@rowland.harvard.edu>

Alan, Thanks for the quick ack. I will send v8 with your ack on first
patch (that touches *hci )

Thanks
--
~Vinod