Re: [PATCH v7 1/5] usb: hci: add hc_driver as argument for usb_hcd_pci_probe

kbuild test robot
2020-03-23T14:50:26Z

[-- Attachment #1: Type: text/plain, Size: 2055 bytes --]

Hi Vinod,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.6-rc7]
[also build test ERROR on next-20200323]
[cannot apply to usb/usb-testing]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url: https://github.com/0day-ci/linux/commits/Vinod-Koul/usb-xhci-Add-support-for-Renesas-USB-controllers/20200323-203447
base: 16fbf79b0f83bc752cee8589279f1ebfe57b3b6e
config: x86_64-defconfig (attached as .config)
compiler: clang version 11.0.0 (https://github.com/llvm/llvm-project 006244152d6c7dd6a390ff89b236cc7801834b46)
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
COMPILER=clang make.cross ARCH=x86_64

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@intel.com>

All errors (new ones prefixed by >>):

In file included from drivers/usb/host/uhci-hcd.c:847:
>> drivers/usb/host/uhci-pci.c:297:36: error: passing 'const struct hc_driver *' to parameter of type 'struct hc_driver *' discards qualifiers [-Werror,-Wincompatible-pointer-types-discards-qualifiers]
return usb_hcd_pci_probe(dev, id, &uhci_driver);
^~~~~~~~~~~~
include/linux/usb/hcd.h:483:27: note: passing argument to parameter 'driver' here
struct hc_driver *driver);
^
1 error generated.

vim +297 drivers/usb/host/uhci-pci.c

294
295 static int uhci_pci_probe(struct pci_dev *dev, const struct pci_device_id *id)
296 {
> 297 return usb_hcd_pci_probe(dev, id, &uhci_driver);
298 }
299

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 29216 bytes --]