RE: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h

Brian Cain
2020-03-23T21:46:59Z

> -----Original Message-----
> From: Thomas Gleixner <tglx@linutronix.de>
...
> Subject: [patch V3 08/20] hexagon: Remove mm.h from asm/uaccess.h
>
> From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
>
> The defconfig compiles without linux/mm.h. With mm.h included the include
> chain leands to:
> | CC kernel/locking/percpu-rwsem.o
> | In file included from include/linux/huge_mm.h:8,
> | from include/linux/mm.h:567,
> | from arch/hexagon/include/asm/uaccess.h:,
> | from include/linux/uaccess.h:11,
> | from include/linux/sched/task.h:11,
> | from include/linux/sched/signal.h:9,
> | from include/linux/rcuwait.h:6,
> | from include/linux/percpu-rwsem.h:8,
> | from kernel/locking/percpu-rwsem.c:6:
> | include/linux/fs.h:1422:29: error: array type has incomplete element type
> 'struct percpu_rw_semaphore'
> | 1422 | struct percpu_rw_semaphore rw_sem[SB_FREEZE_LEVELS];
>
> once rcuwait.h includes linux/sched/signal.h.
>
> Remove the linux/mm.h include.
>
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
> Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
> Cc: Brian Cain <bcain@codeaurora.org>
> Cc: linux-hexagon@vger.kernel.org
> ---
> V3: New patch
> ---
> arch/hexagon/include/asm/uaccess.h | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/hexagon/include/asm/uaccess.h
> b/arch/hexagon/include/asm/uaccess.h
> index 00cb38faad0c4..c1019a736ff13 100644
> --- a/arch/hexagon/include/asm/uaccess.h
> +++ b/arch/hexagon/include/asm/uaccess.h
> @@ -10,7 +10,6 @@
> /*
> * User space memory access functions
> */
> -#include <linux/mm.h>
> #include <asm/sections.h>
>
> /*
> --
> 2.26.0.rc2
>

Acked-by: Brian Cain <bcain@codeaurora.org>