From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>,
gregkh@linuxfoundation.org, hariprasad.kelam@gmail.com,
colin.king@canonical.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, ldv-project@linuxtesting.org,
andrianov@ispras.ru
Subject: Re: [PATCH] usb: host: u132-hcd: Remove u132_static_list
Date: Fri, 3 Apr 2020 23:41:45 +0530 [thread overview]
Message-ID: <20200403181145.GA7574@madhuparna-HP-Notebook> (raw)
In-Reply-To: <Pine.LNX.4.44L0.2004031038200.7035-100000@netrider.rowland.org>
On Fri, Apr 03, 2020 at 10:39:33AM -0400, Alan Stern wrote:
> On Fri, 3 Apr 2020 madhuparnabhowmik10@gmail.com wrote:
>
> > From: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> >
> > u132_static_list is a global list protected by u132_module_lock.
> > It is read in the u132_hcd_exit() function without holding the lock
> > thus may lead to data race.
> > However, it turns out that this list isn't used for anything useful
> > and thus it is okay to get rid of it.
> > Thus, remove the u132_static_list from u132-hcd module.
> >
> > Found by Linux Driver Verification project (linuxtesting.org).
> >
> > Suggested-by: Alan Stern <stern@rowland.harvard.edu>
> > Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik10@gmail.com>
> > ---
> > drivers/usb/host/u132-hcd.c | 8 --------
> > 1 file changed, 8 deletions(-)
> >
> > diff --git a/drivers/usb/host/u132-hcd.c b/drivers/usb/host/u132-hcd.c
> > index e9209e3e6248..52f70cf063ea 100644
> > --- a/drivers/usb/host/u132-hcd.c
> > +++ b/drivers/usb/host/u132-hcd.c
> > @@ -81,7 +81,6 @@ static DECLARE_WAIT_QUEUE_HEAD(u132_hcd_wait);
> > static struct mutex u132_module_lock;
> > static int u132_exiting;
> > static int u132_instances;
> > -static struct list_head u132_static_list;
> > /*
> > * end of the global variables protected by u132_module_lock
> > */
>
> You forgot to remove the u132_list member from struct u132.
>
Thank you for letting me know, I will send the patch again with this
change.
Regards,
Madhuparna
> Alan Stern
>
prev parent reply other threads:[~2020-04-03 18:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 23:22 [PATCH] usb: host: u132-hcd: Remove u132_static_list madhuparnabhowmik10
2020-04-03 14:39 ` Alan Stern
2020-04-03 18:11 ` Madhuparna Bhowmik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200403181145.GA7574@madhuparna-HP-Notebook \
--to=madhuparnabhowmik10@gmail.com \
--cc=andrianov@ispras.ru \
--cc=colin.king@canonical.com \
--cc=gregkh@linuxfoundation.org \
--cc=hariprasad.kelam@gmail.com \
--cc=ldv-project@linuxtesting.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox