From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6F8CC2BA2B for ; Sun, 19 Apr 2020 06:02:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C55E221973 for ; Sun, 19 Apr 2020 06:02:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587276174; bh=r2AgjpwBy563/SvDhTEdOgTQsrTjb6KChd2dLbtCIIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=eVxi0oJg5QPCraoQwWCXwFomIx5D+3SX622DeGNECKfSyQNHD45wvNzJxNETuLaIm JinSFlf034qnHV7X4J1kHtKS4v/7yKHabyzGMC0MxKO1kbbLn1DbvI4+aJG0p9qasg Hvit47USxMxNMn8fJbkt6fnjmigWP+gnJurtcNjY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726026AbgDSGCv (ORCPT ); Sun, 19 Apr 2020 02:02:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:60178 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725914AbgDSGCu (ORCPT ); Sun, 19 Apr 2020 02:02:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A4A4B2076A; Sun, 19 Apr 2020 06:02:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587276170; bh=r2AgjpwBy563/SvDhTEdOgTQsrTjb6KChd2dLbtCIIs=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=pTMv1wODwFpdjz0FVgzA+p2WSCpvCxj18+/q3aiIPhhtKR+jsjHHIdl5zJ2q2+RA3 +Tdmi8jGAiqk3VTvUYzIU3dTg9Q3SKwo6y6sZDkWyGvygbRRccfGpH1VpT4kAcKc5E 4lTNQxLSLwDJyeMo2kAEPugwsa59XjBdxg3VhiTs= Date: Sun, 19 Apr 2020 08:02:47 +0200 From: Greg Kroah-Hartman To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Andrew Morton , Alexander Viro , linux-fsdevel@vger.kernel.org, Dmitry Torokhov , linux-input@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , alsa-devel@alsa-project.org, linux-usb@vger.kernel.org, "J. Bruce Fields" , Chuck Lever , linux-nfs@vger.kernel.org, Johannes Berg , Dan Williams , Vishal Verma , Dave Jiang , linux-nvdimm@lists.01.org, "Martin K. Petersen" , linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, Zzy Wysm Subject: Re: [PATCH 7/9] drivers/base: fix empty-body warnings in devcoredump.c Message-ID: <20200419060247.GA3535909@kroah.com> References: <20200418184111.13401-1-rdunlap@infradead.org> <20200418184111.13401-8-rdunlap@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20200418184111.13401-8-rdunlap@infradead.org> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Sat, Apr 18, 2020 at 11:41:09AM -0700, Randy Dunlap wrote: > Fix gcc empty-body warning when -Wextra is used: > > ../drivers/base/devcoredump.c:297:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > ../drivers/base/devcoredump.c:301:42: warning: suggest braces around empty body in an ‘if’ statement [-Wempty-body] > > Signed-off-by: Randy Dunlap > Cc: Johannes Berg > Cc: Linus Torvalds > Cc: Andrew Morton > --- > drivers/base/devcoredump.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > --- linux-next-20200417.orig/drivers/base/devcoredump.c > +++ linux-next-20200417/drivers/base/devcoredump.c > @@ -9,6 +9,7 @@ > * > * Author: Johannes Berg > */ > +#include Why the need for this .h file being added for reformatting the code? thanks, greg k-h