From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 159D0C83001 for ; Tue, 28 Apr 2020 17:58:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E86B720B80 for ; Tue, 28 Apr 2020 17:58:31 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=oracle.com header.i=@oracle.com header.b="rkQ2Izzk" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728605AbgD1R62 (ORCPT ); Tue, 28 Apr 2020 13:58:28 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:47288 "EHLO userp2120.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727827AbgD1R61 (ORCPT ); Tue, 28 Apr 2020 13:58:27 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03SHrGHc156636; Tue, 28 Apr 2020 17:58:24 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=corp-2020-01-29; bh=bMHDr+peVKNDWx4zqP+LW/B+GykIpmD+phvceywSp1w=; b=rkQ2IzzkF8PqzV2M1/XQEJNFSKjbV3RC61KpVOGXVMkUQG/RnY2Oa2AnAEDRSMaxfrKy vamxqO6OidRyrN9xSHAKUY37tuFSrKkiIway9FM71uCq3SEam5iXyUivWDGZjJ8T8Aly tnQXFHgvImDeZV87HFKx3xjtWXgo61nkoIcmN0pTIcp7bytTdQCCQ9csCuGmlp+llPLz nYxi5xcwLDzPfynQo3eVUpYbFLeZnSELK3QCB5Th8+PzHLcbupnSsAqjVzK/JV8TQ19q x77bId0TfcFhMX95sfsrercyf9kkcuZ5+lMrJVp4PbX7HazicSeOAoueqODzM6SEkCLq VA== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 30p2p06x0c-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Apr 2020 17:58:24 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 03SHw14j154893; Tue, 28 Apr 2020 17:58:23 GMT Received: from userv0122.oracle.com (userv0122.oracle.com [156.151.31.75]) by aserp3030.oracle.com with ESMTP id 30mxrt3krk-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Tue, 28 Apr 2020 17:58:23 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by userv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 03SHwLO4024934; Tue, 28 Apr 2020 17:58:21 GMT Received: from kadam (/41.57.98.10) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Tue, 28 Apr 2020 10:58:21 -0700 Date: Tue, 28 Apr 2020 20:58:14 +0300 From: Dan Carpenter To: Christophe JAILLET Cc: balbi@kernel.org, gregkh@linuxfoundation.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org Subject: Re: [PATCH] usb: phy: twl6030-usb: Fix a resource leak in an error handling path in 'twl6030_usb_probe()' Message-ID: <20200428175814.GI2014@kadam> References: <20200427202116.94380-1-christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200427202116.94380-1-christophe.jaillet@wanadoo.fr> User-Agent: Mutt/1.9.4 (2018-02-28) X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9605 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 phishscore=0 suspectscore=2 mlxlogscore=938 malwarescore=0 bulkscore=0 spamscore=0 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004280143 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9605 signatures=668686 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 spamscore=0 phishscore=0 clxscore=1015 bulkscore=0 adultscore=0 lowpriorityscore=0 impostorscore=0 malwarescore=0 mlxscore=0 suspectscore=2 mlxlogscore=993 priorityscore=1501 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2004280142 Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Mon, Apr 27, 2020 at 10:21:16PM +0200, Christophe JAILLET wrote: > A call to 'regulator_get()' is hidden in 'twl6030_usb_ldo_init()'. A > corresponding put must be performed in the error handling path, as > already done in the remove function. > > While at it, also move a 'free_irq()' call in the error handling path in > order to be consistent. > > Signed-off-by: Christophe JAILLET > --- > Maybe adding a 'twl6030_usb_ldo_uninit()' function would be more explicit. It would be nicer, yes, but probably this is fine too. Reviewed-by: Dan Carpenter regards, dan carpenter