linux-usb.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Oliver Neukum <oneukum@suse.com>
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH] UAS: add quirk for LaCie 2Big Quadra
Date: Wed, 29 Apr 2020 11:33:44 +0200	[thread overview]
Message-ID: <20200429093344.GA2080215@kroah.com> (raw)
In-Reply-To: <20200429083204.21428-1-oneukum@suse.com>

On Wed, Apr 29, 2020 at 10:32:04AM +0200, Oliver Neukum wrote:
> This device needs US_FL_NO_REPORT_OPCODES to avoid going
> through prolonged error handling on enumeration.
> 
> Signed-off-by: Oliver Neukum <oneukum@suse.com>
> Cc: stable <stable@vger.kernel.org>
> Reported-by: Julian Groß <julian.g@posteo.de>
> ---
>  drivers/usb/storage/unusual_uas.h | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index cfdec74e0f4a..d6c54b5bde75 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -73,6 +73,13 @@ UNUSUAL_DEV(0x152d, 0x0578, 0x0000, 0x9999,
>  		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
>  		US_FL_BROKEN_FUA),
>  
> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
> +		"LaCie",
> +		"2Big Quadra USB3",
> +		USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> +		US_FL_NO_REPORT_OPCODES),
> +

Can you please keep these in sorted order by vendor/product id as the
comment in the file suggests to do so?

thanks,

greg k-h

  reply	other threads:[~2020-04-29  9:33 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-29  8:32 [PATCH] UAS: add quirk for LaCie 2Big Quadra Oliver Neukum
2020-04-29  9:33 ` Greg KH [this message]
2020-04-29 10:33   ` Oliver Neukum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200429093344.GA2080215@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=oneukum@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).