From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DFDC83000 for ; Wed, 29 Apr 2020 17:59:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E51B222205 for ; Wed, 29 Apr 2020 17:59:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588183193; bh=uKVXdg34+bztAgTFd7nuch2OdjnH6f6f+YwPjkMWGJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:List-ID:From; b=Ny85/Xo8oDHEMQA/TeaQVWG/mcGFdbfW1czcTaKQ+81AWL6C6PivcV9PUgj47Oyqq mR4mjTJM7pC2PJkIIrWJJsrOYsRRj2lUfswM3+9oyhc28WPWNO+N/doaFzCouBn5m/ KWdrRvp4R4j2GyI1EsCrcQWp3U+9iOp6hKf8CgmY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726955AbgD2R7t (ORCPT ); Wed, 29 Apr 2020 13:59:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:38858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726423AbgD2R7t (ORCPT ); Wed, 29 Apr 2020 13:59:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B68C920B1F; Wed, 29 Apr 2020 17:59:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588183188; bh=uKVXdg34+bztAgTFd7nuch2OdjnH6f6f+YwPjkMWGJ4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=VLvmgh5hiOXOYRzq7Pe1/72+ImTN2ycukWM8kmUNAR15gTXhEk7L+yYFGVWajg9pu PIKUvU80FG+ouSVjL3CIaNL2OTaIAHZqA+CYzmxlEljPRhW6ZfivpZ1Z9YjeyGNHJE EpXZO5nLcbeBl6X/mdfmq/ho7KQWwausMJPZ7QqY= Date: Wed, 29 Apr 2020 19:59:45 +0200 From: Greg KH To: Manivannan Sadhasivam Cc: johan@kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, patong.mxl@gmail.com, Linus Walleij , linux-gpio@vger.kernel.org Subject: Re: [PATCH 2/2] usb: serial: xr_serial: Add gpiochip support Message-ID: <20200429175945.GA2336267@kroah.com> References: <20200428195651.6793-1-mani@kernel.org> <20200428195651.6793-3-mani@kernel.org> <20200429174727.GF6443@Mani-XPS-13-9360> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20200429174727.GF6443@Mani-XPS-13-9360> Sender: linux-usb-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-usb@vger.kernel.org On Wed, Apr 29, 2020 at 11:17:27PM +0530, Manivannan Sadhasivam wrote: > Hi Greg, > > On Wed, Apr 29, 2020 at 01:26:51AM +0530, mani@kernel.org wrote: > > From: Manivannan Sadhasivam > > > > Add gpiochip support for Maxlinear/Exar USB to serial converter > > for controlling the available gpios. > > > > Cc: Linus Walleij > > Cc: linux-gpio@vger.kernel.org > > Signed-off-by: Manivannan Sadhasivam > > --- > > drivers/usb/serial/xr_serial.c | 186 ++++++++++++++++++++++++++++++++- > > drivers/usb/serial/xr_serial.h | 7 ++ > > 2 files changed, 192 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/usb/serial/xr_serial.c b/drivers/usb/serial/xr_serial.c > > index ea4a0b167d3f..d86fd40839f8 100644 > > --- a/drivers/usb/serial/xr_serial.c > > +++ b/drivers/usb/serial/xr_serial.c > > @@ -476,6 +476,189 @@ static void xr_break_ctl(struct tty_struct *tty, int break_state) > > state); > > } > > > > +#ifdef CONFIG_GPIOLIB > > + > > [...] > > > + > > +static int xr_gpio_init(struct usb_serial_port *port) > > +{ > > + struct xr_port_private *port_priv = usb_get_serial_port_data(port); > > + int ret = 0; > > + > > + if (port_priv->idProduct == XR21V141X_ID) > > + ret = xr21v141x_gpio_init(port); > > + > > + if (ret < 0) > > + return ret; > > + > > + port_priv->gc.label = "xr_gpios"; > > + port_priv->gc.request = xr_gpio_request; > > + port_priv->gc.get_direction = xr_gpio_direction_get; > > + port_priv->gc.direction_input = xr_gpio_direction_input; > > + port_priv->gc.direction_output = xr_gpio_direction_output; > > + port_priv->gc.get = xr_gpio_get; > > + port_priv->gc.set = xr_gpio_set; > > + port_priv->gc.owner = THIS_MODULE; > > + port_priv->gc.parent = &port->dev; > > + port_priv->gc.base = -1; > > + port_priv->gc.can_sleep = true; > > + > > + ret = gpiochip_add_data(&port_priv->gc, port); > > + if (!ret) > > + port_priv->gpio_registered = true; > > + > > + return ret; > > +} > > + > > +static void xr_gpio_remove(struct usb_serial_port *port) > > +{ > > + struct xr_port_private *port_priv = usb_get_serial_port_data(port); > > + > > + if (port_priv->gpio_registered) { > > + gpiochip_remove(&port_priv->gc); > > + port_priv->gpio_registered = false; > > + } > > +} > > + > > +#else > > + > > +static int xr_gpio_init(struct usb_serial_port *port) > > +{ > > + return 0; > > +} > > + > > +static void xr_gpio_remove(struct usb_serial_port *port) > > +{ > > + /* Nothing to do */ > > +} > > + > > +#endif > > + > > static int xr_port_probe(struct usb_serial_port *port) > > { > > struct usb_serial *serial = port->serial; > > @@ -495,13 +678,14 @@ static int xr_port_probe(struct usb_serial_port *port) > > > > usb_set_serial_port_data(port, port_priv); > > > > - return 0; > > + return xr_gpio_init(port); > > Just realised that the gpiochip is registered for 2 interfaces exposed by > this chip. This is due to the fact that this chip presents CDC-ACM model, > so there are 2 interfaces (interrupt and bulk IN/OUT). > > We shouldn't need gpiochip for interface 0. So what is the recommended way > to filter that? Not create the gpiochip for interface 0? :) I really don't know what else to say here, sorry. greg k-h