From: Greg KH <gregkh@linuxfoundation.org>
To: mani@kernel.org
Cc: johan@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, patong.mxl@gmail.com
Subject: Re: [PATCH v2 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver
Date: Thu, 30 Apr 2020 08:27:37 +0200 [thread overview]
Message-ID: <20200430062737.GA2376664@kroah.com> (raw)
In-Reply-To: <20200430043636.8468-2-mani@kernel.org>
On Thu, Apr 30, 2020 at 10:06:35AM +0530, mani@kernel.org wrote:
> + port_priv->idProduct = le16_to_cpu(serial->dev->descriptor.idProduct);
> +
> + /* XR21V141X specific settings */
> + if (port_priv->idProduct == XR21V141X_ID) {
> + port_priv->regs = &xr21v141x_regs;
> + port_priv->reg_width = 1;
> + }
Shouldn't you abort here if idProduct does not have this value, as
that's all you test for everywhere else. Do you even need to have this
test and save the value everywhere at all?
thanks,
greg k-h
next prev parent reply other threads:[~2020-04-30 6:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 4:36 [PATCH v2 0/2] Add support for MaxLinear/Exar USB to serial converters mani
2020-04-30 4:36 ` [PATCH v2 1/2] usb: serial: Add MaxLinear/Exar USB to Serial driver mani
2020-04-30 6:27 ` Greg KH [this message]
2020-04-30 17:50 ` Manivannan Sadhasivam
2020-04-30 4:36 ` [PATCH v2 2/2] usb: serial: xr_serial: Add gpiochip support mani
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200430062737.GA2376664@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mani@kernel.org \
--cc=patong.mxl@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).