From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Hans de Goede <hdegoede@redhat.com>
Cc: "Oliver Neukum" <oneukum@suse.com>,
"Alan Stern" <stern@rowland.harvard.edu>,
linux-usb@vger.kernel.org, linux-scsi@vger.kernel.org,
"Julian Groß" <julian.g@posteo.de>
Subject: Re: [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk
Date: Thu, 7 May 2020 15:49:21 +0200 [thread overview]
Message-ID: <20200507134921.GA1798390@kroah.com> (raw)
In-Reply-To: <20200507131708.250871-1-hdegoede@redhat.com>
On Thu, May 07, 2020 at 03:17:08PM +0200, Hans de Goede wrote:
> The LaCie 2Big Quadra USB3 external disk does not like the REPORT_OPCODES
> request, causing probing it to take several minutes (and several resets).
>
> Add US_FL_NO_REPORT_OPCODES flag for this model to fix the probing delay.
>
> Reported-by: Julian Groß <julian.g@posteo.de>
> Signed-off-by: Hans de Goede <hdegoede@redhat.com>
> ---
> drivers/usb/storage/unusual_uas.h | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/drivers/usb/storage/unusual_uas.h b/drivers/usb/storage/unusual_uas.h
> index 1b23741036ee..37157ed9a881 100644
> --- a/drivers/usb/storage/unusual_uas.h
> +++ b/drivers/usb/storage/unusual_uas.h
> @@ -28,6 +28,13 @@
> * and don't forget to CC: the USB development list <linux-usb@vger.kernel.org>
> */
>
> +/* Reported-by: Julian Groß <julian.g@posteo.de> */
> +UNUSUAL_DEV(0x059f, 0x105f, 0x0000, 0x9999,
> + "LaCie",
> + "2Big Quadra USB3",
> + USB_SC_DEVICE, USB_PR_DEVICE, NULL,
> + US_FL_NO_REPORT_OPCODES),
> +
> /*
> * Apricorn USB3 dongle sometimes returns "USBSUSBSUSBS" in response to SCSI
> * commands in UAS mode. Observed with the 1.28 firmware; are there others?
> --
> 2.26.0
>
Already in my tree and in linux-next and will go to Linus this week,
sorry.
greg k-h
next prev parent reply other threads:[~2020-05-07 13:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-07 13:17 [PATCH] USB: uas: Add US_FL_NO_REPORT_OPCODES for LaCie 2Big Quadra USB3 external disk Hans de Goede
2020-05-07 13:49 ` Greg Kroah-Hartman [this message]
2020-05-07 13:56 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200507134921.GA1798390@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=julian.g@posteo.de \
--cc=linux-scsi@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=oneukum@suse.com \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox